Improved defaults

Author: tersmitten

.ansible-lint

@@ -1,5 +1,5 @@
 ---
 warn_list:
   - role-name
+  - name[play]
   - name[casing]
-  - '204'

.github/workflows/ci.yml

@@ -65,14 +65,14 @@ jobs:
           python-version: '3.x'
 
       - name: Install test dependencies
-        run: pip install 'ansible${{ matrix.ansible-version }}' molecule[docker] docker
+        run: pip install 'ansible${{ matrix.ansible-version }}' molecule-plugins[docker] docker
 
       - name: Run Molecule tests
         run: |
           molecule test
         env:
           ANSIBLE_FORCE_COLOR: '1'
-          ANSIBLE_VERBOSITY: '3'
+          ANSIBLE_VERBOSITY: '2'
           MOLECULE_DEBUG: '1'
           MOLECULE_DISTRO: "${{ matrix.distro }}"
           PY_COLORS: '1'

README.md

@@ -31,7 +31,7 @@ None
 * `ssh_keys_private_keys.{n}.group`: [default: `owner`]: The name of the group that should own the file
 * `ssh_keys_private_keys.{n}.mode`: [default: `0600`]: The UNIX permission mode bits of the file
 * `ssh_keys_private_keys.{n}.src`: [required]: The local path of the key
-* `ssh_keys_private_keys.{n}.dest`: [default: `id_rsa`]: The remote path of the key (relative to `home/.ssh/`)
+* `ssh_keys_private_keys.{n}.dest`: [default: `src | basename`]: The remote path of the key (relative to `home/.ssh/`)
 * `ssh_keys_private_keys.{n}.dest_absolute`: [optional]: The remote path of the key
 * `ssh_keys_private_keys.{n}.dest_managed`: [default: `true`]: Whether or not the remote path of the key should be created
 * `ssh_keys_private_keys.{n}.state`: [default: `present`]: State
@@ -41,7 +41,7 @@ None
 * `ssh_keys_public_keys.{n}.group`: [default: `owner`]: The name of the group that should own the file
 * `ssh_keys_public_keys.{n}.mode`: [default: `0644`]: The UNIX permission mode bits of the file
 * `ssh_keys_public_keys.{n}.src`: [required]: The local path of the key
-* `ssh_keys_public_keys.{n}.dest`: [default: `id_rsa.pub`]: The remote path of the key (relative to `home/.ssh/`)
+* `ssh_keys_public_keys.{n}.dest`: [default: `src | basename`]: The remote path of the key (relative to `home/.ssh/`)
 * `ssh_keys_public_keys.{n}.dest_absolute`: [optional]: The remote path of the key
 * `ssh_keys_public_keys.{n}.dest_managed`: [default: `true`]: Whether or not the remote path of the key should be created
 * `ssh_keys_public_keys.{n}.state`: [default: `present`]: State
@@ -74,13 +74,13 @@ None
         comment: RSA key
     ssh_keys_private_keys:
       - owner: root
-        src: ../../../files/ssh-keys/id_rsa
+        src: "{{ playbook_dir }}/files/ssh-keys/id_rsa"
     ssh_keys_public_keys:
       - owner: root
-        src: ../../../files/ssh-keys/id_rsa.pub
+        src: "{{ playbook_dir }}/files/ssh-keys/id_rsa.pub"
     ssh_keys_authorized_keys:
       - owner: root
-        src: ../../../files/ssh-keys/id_rsa.pub
+        src: "{{ playbook_dir }}/files/ssh-keys/id_rsa.pub"
     ssh_keys_known_hosts:
       - hostname: github.com
         enctype: ssh-rsa

tasks/general.yml

@@ -2,7 +2,7 @@
 ---
 - name: general | create ssh directory
   ansible.builtin.file:
-    path: "{{ (item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(ssh_keys_private_key_filename)))) | dirname }}"
+    path: "{{ (item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(item.src | basename)))) | dirname }}"
     state: directory
     owner: "{{ item.owner }}"
     group: "{{ item.group | default(item.owner) }}"

tasks/private-keys.yml

@@ -3,7 +3,7 @@
 - name: private-keys | add
   ansible.builtin.copy:
     src: "{{ item.src }}"
-    dest: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(ssh_keys_private_key_filename))) }}"
+    dest: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(item.src | basename))) }}"
     owner: "{{ item.owner }}"
     group: "{{ item.group | default(item.owner) }}"
     mode: "{{ item.mode | default('0600') }}"
@@ -14,7 +14,7 @@
 
 - name: private-keys | remove
   ansible.builtin.file:
-    path: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(ssh_keys_private_key_filename))) }}"
+    path: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(item.src | basename))) }}"
     state: absent
   with_items: "{{ ssh_keys_private_keys }}"
   when: item.state is defined and item.state == 'absent'

tasks/public-keys.yml

@@ -3,7 +3,7 @@
 - name: public-keys | add
   ansible.builtin.copy:
     src: "{{ item.src }}"
-    dest: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(ssh_keys_public_key_filename))) }}"
+    dest: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(item.src | basename))) }}"
     owner: "{{ item.owner }}"
     group: "{{ item.group | default(item.owner) }}"
     mode: "{{ item.mode | default('0644') }}"
@@ -14,7 +14,7 @@
 
 - name: public-keys | remove
   ansible.builtin.file:
-    path: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(ssh_keys_public_key_filename))) }}"
+    path: "{{ item.dest_absolute | default('~' + item.owner + '/' + ssh_keys_sshdir + '/' + (item.dest | default(item.src | basename))) }}"
     state: absent
   with_items: "{{ ssh_keys_public_keys }}"
   when: item.state is defined and item.state == 'absent'

vars/main.yml

@@ -1,8 +1,6 @@
 # vars file
 ---
 ssh_keys_sshdir: '.ssh'
-ssh_keys_private_key_filename: 'id_rsa'
-ssh_keys_public_key_filename: 'id_rsa.pub'
 ssh_keys_known_hosts_path: /etc/ssh/ssh_known_hosts
 _ssh_keys_generate_keys_command: >-
   openssl \