fixup! [MIG] printer_zpl2: Migration to 18.0

Author: vvrossem

printer_zpl2/models/printing_label_zpl2.py

@@ -3,7 +3,9 @@
 
 import base64
 import io
+import itertools
 import logging
+from collections import defaultdict
 
 import requests
 from PIL import Image, ImageOps
@@ -86,9 +88,39 @@ class PrintingLabelZpl2(models.Model):
     labelary_height = fields.Float(string="Height in mm", default=70)
 
     @api.constrains("component_ids")
-    def _check_component_ids(self):
-        if self._has_cycle("component_ids"):
-            raise ValidationError(self.env._("You can not create recursive labels."))
+    def check_recursion(self):
+        cr = self._cr
+        self.flush_recordset(["component_ids"])
+        query = (
+            'SELECT "{}", "{}" FROM "{}" '
+            'WHERE "{}" IN %s AND "{}" IS NOT NULL'.format(
+                "label_id",
+                "sublabel_id",
+                "printing_label_zpl2_component",
+                "label_id",
+                "sublabel_id",
+            )
+        )
+
+        succs = defaultdict(set)  # transitive closure of successors
+        preds = defaultdict(set)  # transitive closure of predecessors
+        todo, done = set(self.ids), set()
+        while todo:
+            cr.execute(query, [tuple(todo)])  # pylint: disable=E8103
+            done.update(todo)
+            todo.clear()
+            for id1, id2 in cr.fetchall():
+                for x, y in itertools.product(
+                    [id1] + list(preds[id1]), [id2] + list(succs[id2])
+                ):
+                    if x == y:
+                        raise ValidationError(
+                            self.env._("You can not create recursive labels.")
+                        )
+                    succs[x].add(y)
+                    preds[y].add(x)
+                if id2 not in done:
+                    todo.add(id2)
 
     def _get_component_data(self, record, component, eval_args):
         if component.data_autofill: