Skip to content

Commit 2102327

Browse files
committed
[FIX] base_report_to_label_printer: _get_user_default_printer is deprecated
1 parent ea9336a commit 2102327

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

base_report_to_label_printer/models/ir_actions_report.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ class IrActionsReport(models.Model):
99

1010
label = fields.Boolean(string="Report is a Label")
1111

12-
def _get_user_default_printer(self, user):
12+
def _get_user_default_print_behaviour(self):
13+
result = super()._get_user_default_print_behaviour()
1314
if self.label:
14-
return user.default_label_printer_id
15-
return super()._get_user_default_printer(user)
15+
user = self.env.user
16+
result["printer"] = user.default_label_printer_id or result["printer"]
17+
return result

base_report_to_label_printer/tests/test_ir_actions_report.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# Copyright (C) 2022 Raumschmiede GmbH - Christopher Hansen (<https://www.raumschmiede.de>)
22
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
33

4-
import logging
4+
5+
from odoo.tools import mute_logger
56

67
from odoo.addons.base.tests.common import BaseCommon
78

@@ -32,22 +33,18 @@ def new_printer(self):
3233
}
3334
)
3435

36+
# @mute_logger("odoo.addons.base_report_to_printer.models.printing_server")
3537
def test_print_behavior_user_label_printer(self):
3638
"""It should return the label printer from user"""
3739
report = self.Model.search([], limit=1)
3840
report.label = True
3941
self.env.user.printing_action = "client"
4042
self.env.user.default_label_printer_id = self.new_printer()
41-
with (
42-
self.assertLogs(level=logging.WARNING) as logs,
43-
):
44-
self.assertEqual(
45-
report.behaviour(),
46-
{
47-
"action": "client",
48-
"printer": self.env.user.default_label_printer_id,
49-
"tray": False,
50-
},
51-
)
52-
self.assertEqual(len(logs.records), 1)
53-
self.assertEqual(logs.records[0].levelno, logging.WARNING)
43+
self.assertEqual(
44+
report.behaviour(),
45+
{
46+
"action": "client",
47+
"printer": self.env.user.default_label_printer_id,
48+
"tray": False,
49+
},
50+
)

0 commit comments

Comments
 (0)