Skip to content

Commit 7ea9860

Browse files
Make ItemWrapper immutable
1 parent b08640a commit 7ea9860

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

invui/src/main/java/xyz/xenondevs/invui/item/ItemWrapper.java

+5-7
Original file line numberDiff line numberDiff line change
@@ -11,28 +11,26 @@
1111
*/
1212
public final class ItemWrapper implements ItemProvider {
1313

14-
private ItemStack itemStack;
14+
private final ItemStack itemStack;
1515

1616
public ItemWrapper(ItemStack itemStack) {
17-
this.itemStack = itemStack;
17+
this.itemStack = itemStack.clone();
1818
}
1919

2020
@Override
2121
public ItemStack get(Locale locale) {
22-
return itemStack;
22+
return itemStack.clone();
2323
}
2424

2525
@Override
2626
public ItemStack get() {
27-
return itemStack;
27+
return itemStack.clone();
2828
}
2929

3030
@Override
3131
public ItemWrapper clone() {
3232
try {
33-
ItemWrapper clone = (ItemWrapper) super.clone();
34-
clone.itemStack = itemStack.clone();
35-
return clone;
33+
return (ItemWrapper) super.clone();
3634
} catch (CloneNotSupportedException e) {
3735
throw new AssertionError(e);
3836
}

0 commit comments

Comments
 (0)