feat: Combined layout for transactions #3304
Draft
+103
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infrmtcs
force-pushed
the
dat/bench/combined
branch
from
51d15ae to
6c07e08
Compare
This was referenced Nov 25, 2025
infrmtcs
force-pushed
the
dat/accessors
branch
from
805ba7f to
4656507
Compare
infrmtcs
force-pushed
the
dat/bench/combined
branch
from
6c07e08 to
5817864
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dat/accessors #3304 +/- ##
=================================================
- Coverage 76.22% 76.21% -0.01%
=================================================
Files 343 343
Lines 32517 32512 -5
=================================================
- Hits 24785 24779 -6
- Misses 5949 5955 +6
+ Partials 1783 1778 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodrigo-pino
reviewed
Dec 1, 2025
Comment on lines
+252
to
+257
| if err := core.WriteTransactionsAndReceipts( | ||
| txn, | ||
| block.Number, | ||
| block.Transactions, | ||
| block.Receipts, | ||
| ); err != nil { |
Collaborator
There was a problem hiding this comment.
Let's separate the assign from the if please
Comment on lines
+723
to
+728
| if err := core.WriteTransactionsAndReceipts( | ||
| txn, | ||
| block.Number, | ||
| block.Transactions, | ||
| block.Receipts, | ||
| ); err != nil { |
infrmtcs
force-pushed
the
dat/accessors
branch
from
4656507 to
d8b7d95
Compare
infrmtcs
force-pushed
the
dat/bench/combined
branch
from
5817864 to
4d5ee18
Compare
infrmtcs
force-pushed
the
dat/accessors
branch
from
d8b7d95 to
a2282bd
Compare
infrmtcs
force-pushed
the
dat/bench/combined
branch
from
4d5ee18 to
85e62f4
Compare
infrmtcs
force-pushed
the
dat/accessors
branch
from
a2282bd to
efab75b
Compare
infrmtcs
force-pushed
the
dat/bench/combined
branch
from
85e62f4 to
2dfe1e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.