Skip to content

Conversation

@MaksymMalicki
Copy link
Contributor

This PR addresses this comment, and uses more descriptive felt.Address type for owner fields in all triedb and trie2 packages

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.24%. Comparing base (6fed3dc) to head (090e07a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
core/trie2/triedb/pathdb/nodeset.go 50.00% 20 Missing and 3 partials ⚠️
core/state/object.go 0.00% 7 Missing ⚠️
core/trie2/triedb/hashdb/database.go 88.88% 3 Missing and 3 partials ⚠️
core/felt/utils.go 42.85% 4 Missing ⚠️
core/trie2/triedb/pathdb/disklayer.go 60.00% 0 Missing and 2 partials ⚠️
core/state/state.go 50.00% 0 Missing and 1 partial ⚠️
core/trie2/errors.go 0.00% 1 Missing ⚠️
core/trie2/triedb/empty.go 0.00% 1 Missing ⚠️
core/trie2/triedb/pathdb/cache.go 75.00% 1 Missing ⚠️
core/trie2/triedb/pathdb/database.go 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3295      +/-   ##
==========================================
+ Coverage   76.18%   76.24%   +0.06%     
==========================================
  Files         340      346       +6     
  Lines       32611    32690      +79     
==========================================
+ Hits        24845    24926      +81     
- Misses       5969     5977       +8     
+ Partials     1797     1787      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor comments regarding should we do the same for Hash types. Also nitpick regarding formatting long function signatures, I prefer one parameter per line formatting for long function signatures and calls rather than

func longFunction(
param1, param2 .......
)

Base automatically changed from maksym/rawdb-clean to main December 2, 2025 14:05
@MaksymMalicki MaksymMalicki force-pushed the maksym/refactor-triedb-address branch from ee257ec to 7274438 Compare December 2, 2025 14:34
Copy link
Contributor

@infrmtcs infrmtcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, thanks

Copy link
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@infrmtcs infrmtcs merged commit 584e500 into main Dec 4, 2025
20 of 21 checks passed
@infrmtcs infrmtcs deleted the maksym/refactor-triedb-address branch December 4, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants