-
Notifications
You must be signed in to change notification settings - Fork 220
refactor(trie2): use more descriptive felt.Address type instead of felt.Felt
#3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
+ Coverage 76.18% 76.24% +0.06%
==========================================
Files 340 346 +6
Lines 32611 32690 +79
==========================================
+ Hits 24845 24926 +81
- Misses 5969 5977 +8
+ Partials 1797 1787 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
373032d to
4a7808a
Compare
EgeCaner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor comments regarding should we do the same for Hash types. Also nitpick regarding formatting long function signatures, I prefer one parameter per line formatting for long function signatures and calls rather than
func longFunction(
param1, param2 .......
)225d960 to
2168fca
Compare
ee257ec to
7274438
Compare
infrmtcs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM, thanks
…d of `felt.Felt`
…d of `felt.Felt`
9210f6f to
090e07a
Compare
EgeCaner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
This PR addresses this comment, and uses more descriptive
felt.Addresstype for owner fields in alltriedbandtrie2packages