Fix StringSchema.bound method min,max length #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemisMucaj
force-pushed
the
amucaj-fix-tlv-string-bound
branch
from
594f7dd to
577efe8
Compare
Fixes bug reported on Discord whereby async "changed" observers cause an infinite loop when the transaction commits. Async reactors only install a synchronous observers so this is apparently not a common code path. Also added tests on AsyncObservable (does not exhibit bug) and OnOffServer#events#onOff$Changed (does exhibit bug).
ArtemisMucaj
force-pushed
the
amucaj-fix-tlv-string-bound
branch
from
e3f0c3a to
a15308d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.