Further improve coverage

Author: NeonGraal

Diff for: src/GqlPlus.Converter.Json/Convert/RenderJsonConverter.cs

@@ -5,10 +5,6 @@ internal abstract class RenderJsonConverter<T>
 {
   protected void WriteValue(Utf8JsonWriter writer, StructureValue value)
   {
-    if (value is null || value.IsEmpty) {
-      return;
-    }
-
     if (value.Identifier is not null) {
       writer.WriteStringValue(value.Identifier);
     } else if (value.Boolean is not null) {

Diff for: src/GqlPlus.Converter.Json/Convert/RenderStructureJsonConverter.cs

@@ -1,16 +1,15 @@
-namespace GqlPlus.Convert;
+using System.Diagnostics.CodeAnalysis;
+
+namespace GqlPlus.Convert;
 internal class RenderStructureJsonConverter
   : RenderJsonConverter<Structured>
 {
   internal static RenderValueJsonConverter ValueConverter { get; } = new();
 
+  [ExcludeFromCodeCoverage]
   public override Structured? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) => throw new NotImplementedException();
   public override void Write(Utf8JsonWriter writer, Structured value, JsonSerializerOptions options)
   {
-    if (value is null || value.IsEmpty) {
-      return;
-    }
-
     bool plain = string.IsNullOrWhiteSpace(value.Tag);
 
     if (value.List.Count > 0) {

Diff for: src/GqlPlus.Converter.Json/Convert/RenderValueJsonConverter.cs

@@ -1,15 +1,14 @@
-namespace GqlPlus.Convert;
+using System.Diagnostics.CodeAnalysis;
+
+namespace GqlPlus.Convert;
 
 internal class RenderValueJsonConverter
   : RenderJsonConverter<StructureValue>
 {
+  [ExcludeFromCodeCoverage]
   public override StructureValue? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options) => throw new NotImplementedException();
   public override void Write(Utf8JsonWriter writer, StructureValue value, JsonSerializerOptions options)
   {
-    if (value is null || value.IsEmpty) {
-      return;
-    }
-
     if (string.IsNullOrWhiteSpace(value.Tag)) {
       WriteValue(writer, value);
       return;

Diff for: src/GqlPlus.Converter.Yaml/Convert/RenderYaml.cs

@@ -32,7 +32,4 @@ static RenderYaml()
 
   public static string ToYaml(this Structured model, bool wrapped)
     => (wrapped ? YamlWrapped : YamlFull).Serialize(model);
-
-  public static string YamlJoin(this IEnumerable<string> list, string start, string end)
-    => start + string.Join(", ", list ?? []) + end;
 }

Diff for: src/GqlPlus.Converter.Yaml/Convert/RenderYamlTypeConverter.cs

@@ -1,4 +1,5 @@
-using YamlDotNet.Core.Events;
+using System.Diagnostics.CodeAnalysis;
+using YamlDotNet.Core.Events;
 
 namespace GqlPlus.Convert;
 
@@ -24,8 +25,11 @@ internal class RenderYamlTypeConverter
 {
   public bool Accepts(Type type) => type == typeof(Structured);
 
+  [ExcludeFromCodeCoverage]
   public object? ReadYaml(IParser parser, Type type) => throw new NotImplementedException();
+  [ExcludeFromCodeCoverage]
   public object? ReadYaml(IParser parser, Type type, ObjectDeserializer rootDeserializer) => throw new NotImplementedException();
+
   public void WriteYaml(IEmitter emitter, object? value, Type type, ObjectSerializer serializer)
   {
     if (value is Structured model) {

Diff for: src/GqlPlus.Verifier/Verifying/Schema/UsageContext.cs

@@ -110,10 +110,6 @@ internal static TContext CheckType<TContext, TObjBase>(this TContext context, TO
     where TContext : UsageContext
     where TObjBase : IGqlpObjType
   {
-    if (type is null) {
-      return context;
-    }
-
     string typeName = (type.IsTypeParam ? "$" : "") + type.Name;
     if (context.GetType(typeName, out IGqlpDescribed? value)) {
       CheckTypeArgs(AddCheckError, type, check, value);

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/category-output-dict.verified.txt

@@ -1,8 +1,7 @@
 !_Schema
 categories: !_Map_Categories
   !_Identifier ctgrOutpDict: !_Category
-    modifiers: [!_ModifierDictionary {by: '*', modifierKind: !_ModifierKind Dict,
-        typeKind: !_SimpleKind Basic}]
+    modifiers: [!_ModifierDictionary {by: '*', modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Basic}]
     name: ctgrOutpDict
     output: !_TypeRef(_TypeKind)
       name: CtgrOutpDict

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/descr-complex.verified.txt

@@ -1,7 +1,6 @@
 !_Schema
 types: !_Map_Type
   !_Identifier DescrCmpl: !_TypeOutput
-    description: >-
-      A "more" 'Complicated' \ description
+    description: "A \"more\" 'Complicated' \\ description"
     name: DescrCmpl
     typeKind: !_TypeKind Output

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-descr.verified.txt

@@ -2,7 +2,6 @@
 directives: !_Map_Directives
   !_Identifier DrctDescr: !_Directive
     description: 'A directive described'
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctDescr
     repeatable: false

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-no-param.verified.txt

@@ -1,7 +1,6 @@
 !_Schema
 directives: !_Map_Directives
   !_Identifier DrctNoParam: !_Directive
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctNoParam
     repeatable: false

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-param-dict.verified.txt

@@ -1,14 +1,12 @@
 !_Schema
 directives: !_Map_Directives
   !_Identifier DrctParamDict: !_Directive
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctParamDict
     parameters:
     - !_InputParam
       input: InDrctParamDict
-      modifiers: [!_ModifierDictionary {by: String, modifierKind: !_ModifierKind Dict,
-          typeKind: !_SimpleKind Basic}]
+      modifiers: [!_ModifierDictionary {by: String, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Basic}]
     repeatable: false
 types: !_Map_Type
   !_Identifier InDrctParamDict: !_TypeInput

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-param-in.verified.txt

@@ -1,8 +1,7 @@
 !_Schema
 directives: !_Map_Directives
   !_Identifier DrctParamIn: !_Directive
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctParamIn
     parameters:
     - !_InputParam

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-param-list.verified.txt

@@ -1,8 +1,7 @@
 !_Schema
 directives: !_Map_Directives
   !_Identifier DrctParamList: !_Directive
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctParamList
     parameters:
     - !_InputParam

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Globals/directive-param-opt.verified.txt

@@ -1,8 +1,7 @@
 !_Schema
 directives: !_Map_Directives
   !_Identifier DrctParamOpt: !_Directive
-    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _,
-      Operation: _, Spread: _, Variable: _}
+    locations: !_Set(_Location) {Field: _, Fragment: _, Inline: _, Operation: _, Spread: _, Variable: _}
     name: DrctParamOpt
     parameters:
     - !_InputParam

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Objects/field-mod-Enum+dual.verified.txt

@@ -3,16 +3,14 @@ types: !_Map_Type
   !_Identifier DualFieldModEnum: !_TypeDual
     allFields:
     - !_ObjectFor(_DualField)
-      modifiers: [!_ModifierDictionary {by: EnumDualFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumDualFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       object: DualFieldModEnum
       type: !_DualBase
         dual: '*'
     fields:
     - !_DualField
-      modifiers: [!_ModifierDictionary {by: EnumDualFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumDualFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       type: !_DualBase
         dual: '*'

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Objects/field-mod-Enum+input.verified.txt

@@ -13,16 +13,14 @@ types: !_Map_Type
   !_Identifier InpFieldModEnum: !_TypeInput
     allFields:
     - !_ObjectFor(_InputField)
-      modifiers: [!_ModifierDictionary {by: EnumInpFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumInpFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       object: InpFieldModEnum
       type: !_InputBase
         input: '*'
     fields:
     - !_InputField
-      modifiers: [!_ModifierDictionary {by: EnumInpFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumInpFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       type: !_InputBase
         input: '*'

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Objects/field-mod-Enum+output.verified.txt

@@ -13,16 +13,14 @@ types: !_Map_Type
   !_Identifier OutpFieldModEnum: !_TypeOutput
     allFields:
     - !_ObjectFor(_OutputField)
-      modifiers: [!_ModifierDictionary {by: EnumOutpFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumOutpFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       object: OutpFieldModEnum
       type: !_OutputBase
         output: '*'
     fields:
     - !_OutputField
-      modifiers: [!_ModifierDictionary {by: EnumOutpFieldModEnum,
-          modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
+      modifiers: [!_ModifierDictionary {by: EnumOutpFieldModEnum, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Enum}]
       name: field
       type: !_OutputBase
         output: '*'

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/SampleYamlTests/Objects/output-param-mod-Domain.verified.txt

@@ -44,8 +44,7 @@ types: !_Map_Type
       parameters:
       - !_InputParam
         input: InOutpParamModDmn
-        modifiers: [!_ModifierDictionary {by: DomOutpParamModDmn,
-            modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Domain}]
+        modifiers: [!_ModifierDictionary {by: DomOutpParamModDmn, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Domain}]
       type: !_OutputBase
         output: DomOutpParamModDmn
     fields:
@@ -54,8 +53,7 @@ types: !_Map_Type
       parameters:
       - !_InputParam
         input: InOutpParamModDmn
-        modifiers: [!_ModifierDictionary {by: DomOutpParamModDmn,
-            modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Domain}]
+        modifiers: [!_ModifierDictionary {by: DomOutpParamModDmn, modifierKind: !_ModifierKind Dict, typeKind: !_SimpleKind Domain}]
       type: !_OutputBase
         output: DomOutpParamModDmn
     name: OutpParamModDmn

Diff for: test/GqlPlus.Converter.Yaml.ComponentTests/Sample/YamlSchemaTests.cs

@@ -7,5 +7,5 @@ ISchemaVerifyChecks checks
 ) : TestSchemaVerify(checks)
 {
   protected override Task VerifyResult(Structured result, string label, string test, string section)
-    => Verify(result.ToYaml(true), CustomSettings(label, "Yaml", test, section));
+    => Verify(result.ToYaml(string.IsNullOrWhiteSpace(section)), CustomSettings(label, "Yaml", test, section));
 }