Skip to content

Conversation

@mrossinek
Copy link

Description

I would like to extend this schema to support active space-based embedding techniques.
For this to work efficiently, we need to add two additions to the schema:

  1. sending MO data directly rather than AO data, in order to allow the minimal set of information to be transferred (i.e. only the active MOs instead of the full AO set)
  2. add fields for the 2-body terms (electron repulsion integrals; short: eri). This will enable this schema to be used to interface two codes where e.g. one of them does not support eri-computation on-the-fly.

Questions

  • How can we generalize the basis in which a matrix is provided in? I naively added some _mo_ named keywords but I don't think this scales well for the future.
  • Can we encode symmetry information for the eri terms? This would permit not having to send O(N^4) numbers when up to 8-fold symmetry could be exploited.

Status

  • Open for discussion

mrossinek added a commit to mrossinek/qiskit-nature that referenced this pull request Aug 2, 2022
Adds the Active-Space extension to the QCSchema as proposed here:
MolSSI/QCSchema#83
mrossinek added a commit to mrossinek/qiskit-nature that referenced this pull request Aug 2, 2022
Adds the Active-Space extension to the QCSchema as proposed here:
MolSSI/QCSchema#83
mrossinek added a commit to mrossinek/qiskit-nature that referenced this pull request Aug 3, 2022
Adds the Active-Space extension to the QCSchema as proposed here:
MolSSI/QCSchema#83
@mrossinek
Copy link
Author

When using this for active spaces, we should also add a field in the properties schema, which can indicate the energy contribution of the inactive space. I'm open to naming suggestions 👍

@mrossinek
Copy link
Author

I would like to discuss this suggestion a bit more. Simply adding the eri as naive as I did here will imply very costly scaling.
Has the team around this schema thought about support for sparse matrices already?

mergify bot pushed a commit to qiskit-community/qiskit-nature that referenced this pull request Aug 8, 2022
* feat: support basic QCSchema

Adds dataclasses to represent data stored in the QCSchema format [1].
Some basic test cases have been taken from the QCSchema test files.

For this to be usable, further changes are required extending the
QCSchema to support active-spaces, by including the two-body terms
directly in the files.
Support for HDF5 files will also need to be added.

[1]: https://molssi-qc-schema.readthedocs.io/en/latest/index.html

* HDF5 integration for QCSchema

* refactor: improve the QCSchema unittests

* test: prepare HDF5 capabilities tests

* feat: Active-Space Extension

Adds the Active-Space extension to the QCSchema as proposed here:
MolSSI/QCSchema#83

* Add reno

* docs: add QCSchema attribute documentation

* Fix sphinx docs

* generalize type hints of QCSchema attributes

* fix: respect optionality of attributes in typehint

* refactor: split QCSchema into multiple files

The qcschema.py file has grown quite substantially. In order to improve
maintainability and class extensions down the road, this refactoring
splits that single file into multiple files.

* refactor unittest to use TemporaryDirectory

The validity of this change has been tested in #770, since the test here
is currently still being skipped.

* Add documentation on optional attributes of QCSchema

Co-authored-by: Manoel Marques <[email protected]>
Anthony-Gandon pushed a commit to Anthony-Gandon/qiskit-nature that referenced this pull request May 25, 2023
* feat: support basic QCSchema

Adds dataclasses to represent data stored in the QCSchema format [1].
Some basic test cases have been taken from the QCSchema test files.

For this to be usable, further changes are required extending the
QCSchema to support active-spaces, by including the two-body terms
directly in the files.
Support for HDF5 files will also need to be added.

[1]: https://molssi-qc-schema.readthedocs.io/en/latest/index.html

* HDF5 integration for QCSchema

* refactor: improve the QCSchema unittests

* test: prepare HDF5 capabilities tests

* feat: Active-Space Extension

Adds the Active-Space extension to the QCSchema as proposed here:
MolSSI/QCSchema#83

* Add reno

* docs: add QCSchema attribute documentation

* Fix sphinx docs

* generalize type hints of QCSchema attributes

* fix: respect optionality of attributes in typehint

* refactor: split QCSchema into multiple files

The qcschema.py file has grown quite substantially. In order to improve
maintainability and class extensions down the road, this refactoring
splits that single file into multiple files.

* refactor unittest to use TemporaryDirectory

The validity of this change has been tested in qiskit-community#770, since the test here
is currently still being skipped.

* Add documentation on optional attributes of QCSchema

Co-authored-by: Manoel Marques <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants