Skip to content

Conversation

@grirgz
Copy link
Contributor

@grirgz grirgz commented Apr 17, 2025

No description provided.

Copy link
Member

@LFSaw LFSaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, please see related review comments

destination.notNil.if {
if ( thisProcess.platform.name == \linux ) {
midiOut = MIDIOut( 0 );
midiOut = MIDIOut( 0, dstID );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated to the title of the PR, please explain why this is necessary and move into a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, you are right, i moved this commit to another pull request ^^

@adcxyz adcxyz merged commit 31e4ee4 into ModalityTeam:master Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants