Merge branch 'feat/component-audit-5541' into 'master'

Component audit phase I #5541

See merge request minds/front!1922

Author: markharding

src/app/app-routing.module.ts

@@ -13,7 +13,6 @@ import { CanDeactivateGuardService } from './services/can-deactivate-guard';
 import { DiscoveryModuleLazyRoutes } from './modules/discovery/discovery.lazy';
 import { CanaryModuleLazyRoutes } from './modules/canary/canary.lazy';
 import { MobileModuleLazyRoutes } from './modules/mobile/mobile.lazy';
-import { HelpdeskModuleLazyRoutes } from './modules/helpdesk/helpdesk.lazy';
 import { AuxModuleLazyRoutes } from './modules/aux-pages/aux-pages.lazy';
 import {
   BlogModuleLazyRoutes,
@@ -29,7 +28,6 @@ const routes: Routes = [
   DiscoveryModuleLazyRoutes,
   CanaryModuleLazyRoutes,
   MobileModuleLazyRoutes,
-  HelpdeskModuleLazyRoutes,
   AuxModuleLazyRoutes,
   BlogModuleLazyRoutes,
   BlogSlugModuleLazyRoutes,

src/app/app.module.ts

@@ -18,15 +18,13 @@ import { Minds } from './app.component';
 import { MINDS_PROVIDERS } from './services/providers';
 
 import { CommonModule } from './common/common.module';
-import { CheckoutModule } from './modules/checkout/checkout.module';
 import { PlusModule } from './modules/plus/plus.module';
 import { I18nModule } from './modules/i18n/i18n.module';
 
 import { AdsModule } from './modules/ads/ads.module';
 import { BoostModule } from './modules/boost/boost.module';
 import { WireModule } from './modules/wire/wire.module';
 import { ReportModule } from './modules/report/report.module';
-//import { ChannelsModule } from './modules/channels/channels.module';
 import { MindsFormsModule } from './modules/forms/forms.module';
 import { LegacyModule } from './modules/legacy/legacy.module';
 import { ModalsModule } from './modules/modals/modals.module';
@@ -84,7 +82,6 @@ import { CompassModule } from './modules/compass/compass.module';
     LayoutModule,
     CommonModule,
     ProModule, // NOTE: Pro Module should be declared _BEFORE_ anything else
-    //CheckoutModule,
     PlusModule,
     AboutModule,
     AdsModule,
@@ -116,7 +113,6 @@ import { CompassModule } from './modules/compass/compass.module';
     CommentsModule,
     JobsMarketingModule,
     IssuesModule,
-    //ChannelsModule,
     UpgradesModule,
     CodeHighlightModule,
     SharedModule,

src/app/common/common.module.ts

@@ -5,10 +5,7 @@ import { FormsModule, ReactiveFormsModule } from '@angular/forms';
 
 import { MINDS_PIPES } from './pipes/pipes';
 
-import { TopbarComponent } from './layout/topbar/topbar.component';
-import { TopbarNavigationComponent } from './layout/topbar/navigation.component';
 import { SidebarNavigationComponent } from './layout/sidebar/navigation.component';
-import { TopbarOptionsComponent } from './layout/topbar/options.component';
 import { TopbarWalletBalance } from './layout/topbar/topbar-wallet-balance/topbar-wallet-balance.component';
 
 import { TooltipComponent } from './components/tooltip/tooltip.component';
@@ -17,9 +14,7 @@ import { SizeableLoadingSpinnerComponent } from './components/sizeable-loading-s
 import { FooterComponent } from './components/footer/footer.component';
 import { InfiniteScroll } from './components/infinite-scroll/infinite-scroll';
 import { CountryInputComponent } from './components/forms/country-input/country-input.component';
-import { DateInputComponent } from './components/forms/date-input/date-input.component';
 import { CityFinderComponent } from './components/forms/city-finder/city-finder.component';
-import { StateInputComponent } from './components/forms/state-input/state-input.component';
 import { ReadMoreDirective } from './read-more/read-more.directive';
 import { ReadMoreButtonComponent } from './read-more/button.component';
 import { ChannelBadgesComponent } from './components/badges/badges.component';
@@ -43,38 +38,26 @@ import { TagsLinks } from './directives/tags';
 import { Tooltip } from './directives/tooltip';
 import { MindsAvatar } from './components/avatar/avatar';
 import { Textarea } from './components/editors/textarea.component';
-import { TagcloudComponent } from './components/tagcloud/tagcloud.component';
 import { DropdownComponent } from './components/dropdown/dropdown.component';
 
 import { DynamicHostDirective } from './directives/dynamic-host.directive';
 import { MindsCard } from './components/card/card.component';
 import { MindsButton } from './components/button-v1/button-v1.component';
 
-import { ChartComponent } from './components/chart/chart.component';
 import { DateSelectorComponent } from './components/date-selector/date-selector.component';
-import { AdminActionsButtonComponent } from './components/button-v1/admin-actions/admin-actions.component';
 import { InlineEditorComponent } from './components/editors/inline-editor.component';
 import { AttachmentService } from '../services/attachment';
-import { MaterialBoundSwitchComponent } from './components/material/bound-switch.component';
 import { IfFeatureDirective } from './directives/if-feature.directive';
 import { IfBrowserDirective } from './directives/if-browser.directive';
-import { MindsEmoji } from './components/emoji/emoji';
-import { CategoriesSelectorComponent } from './components/categories/selector/selector.component';
-import { CategoriesSelectedComponent } from './components/categories/selected/selected.component';
 import { TreeComponent } from './components/tree/tree.component';
 import { AnnouncementComponent } from './components/announcements/announcement.component';
-import { MindsTokenSymbolComponent } from './components/cypto/token-symbol.component';
 import { PhoneInputComponent } from './components/phone-input/phone-input.component';
 import { PhoneInputCountryComponent } from './components/phone-input/country.component';
 import { Session } from '../services/session';
 import { MindsHttpClient } from './api/client.service';
 import { SafeToggleComponent } from './components/safe-toggle/safe-toggle.component';
 import { ThumbsUpButton } from './components/thumbs/thumbs-up.component';
 import { ThumbsDownButton } from './components/thumbs/thumbs-down.component';
-import { DismissableNoticeComponent } from './components/notice/notice.component';
-import { AnalyticsImpressions } from './components/analytics/impressions';
-import { LineGraph } from './components/graphs/line-graph';
-import { PieGraph } from './components/graphs/pie-graph';
 import { GraphSVG } from './components/graphs/svg';
 import { GraphPoints } from './components/graphs/points';
 import { DynamicFormComponent } from './components/forms/dynamic-form/dynamic-form.component';
@@ -84,20 +67,14 @@ import { UpdateMarkersService } from './services/update-markers.service';
 import { SocketsService } from '../services/sockets';
 import { HttpClient } from '@angular/common/http';
 import { AndroidAppDownloadComponent } from './components/android-app-download-button/button.component';
-import { SwitchComponent } from './components/switch/switch.component';
 import { FeaturedContentComponent } from './components/featured-content/featured-content.component';
 import { FeaturedContentService } from './components/featured-content/featured-content.service';
 import { FeedsService } from './services/feeds.service';
-import { HorizontalInfiniteScroll } from './components/infinite-scroll/horizontal-infinite-scroll.component';
-import { PosterDateSelectorComponent } from './components/poster-date-selector/selector.component';
-import { ChannelModeSelectorComponent } from './components/channel-mode-selector/channel-mode-selector.component';
 import { RouterHistoryService } from './services/router-history.service';
 import { DraggableListComponent } from './components/draggable-list/list.component';
 import { DndModule } from 'ngx-drag-drop';
 import { SiteService } from './services/site.service';
 import { ToggleComponent } from './components/toggle/toggle.component';
-import { SidebarMenuComponent } from './components/sidebar-menu/sidebar-menu.component';
-import { PageLayoutComponent } from './components/page-layout/page-layout.component';
 import { DashboardLayoutComponent } from './components/dashboard-layout/dashboard-layout.component';
 import { ShadowboxLayoutComponent } from './components/shadowbox-layout/shadowbox-layout.component';
 import { ShadowboxHeaderComponent } from './components/shadowbox-header/shadowbox-header.component';
@@ -107,14 +84,12 @@ import {
 } from '@danielmoncada/angular-datetime-picker';
 import { DropdownSelectorComponent } from './components/dropdown-selector/dropdown-selector.component';
 import { ButtonComponent } from './components/button/button.component';
-import { FormDescriptorComponent } from './components/form-descriptor/form-descriptor.component';
 import { FormToastComponent } from './components/form-toast/form-toast.component';
 import { SsoService } from './services/sso.service';
 import { ShadowboxHeaderTabsComponent } from './components/shadowbox-header-tabs/shadowbox-header-tabs.component';
 import { TimespanFilterComponent } from './components/timespan-filter/timespan-filter.component';
 import { PagesService } from './services/pages.service';
 import { DateDropdownsComponent } from './components/date-dropdowns/date-dropdowns.component';
-import { EmailConfirmationComponent } from './components/email-confirmation/email-confirmation.component';
 import { CookieService } from './services/cookie.service';
 import { MediaProxyService } from './services/media-proxy.service';
 import { RelatedContentService } from './services/related-content.service';
@@ -169,7 +144,7 @@ import { ChatIconComponent } from './components/chat-icon/chat-icon.component';
 import { PublisherSearchModalComponent } from './components/publisher-search-modal/publisher-search-modal.component';
 import { PublisherSearchModalService } from './services/publisher-search-modal.service';
 import { DateRangeModalComponent } from './components/date-range-modal/date-range-modal.component';
-import { DateRangeModalService } from './components/date-range-modal/date-range-modal.services';
+import { DateRangeModalService } from './components/date-range-modal/date-range-modal.service';
 import { NgxPopperjsModule } from 'ngx-popperjs';
 import { HovercardComponent } from './components/hovercard/hovercard.component';
 import { QRCodeModule } from 'angularx-qrcode';
@@ -220,107 +195,66 @@ const routes: Routes = [
   ],
   declarations: [
     MINDS_PIPES,
-
-    TopbarComponent,
-    TopbarNavigationComponent,
+    MDL_DIRECTIVES,
     SidebarNavigationComponent,
-    TopbarOptionsComponent,
     TopbarWalletBalance,
-
-    // V2 Layout
     V3TopbarComponent,
     UserMenuV3Component,
-
-    //
-
     TooltipComponent,
     QualityScoreComponent,
     SizeableLoadingSpinnerComponent,
     FooterComponent,
     InfiniteScroll,
-    HorizontalInfiniteScroll,
     CountryInputComponent,
-    DateInputComponent,
-    StateInputComponent,
     CityFinderComponent,
     Scheduler,
     Modal,
     ReadMoreDirective,
     ReadMoreButtonComponent,
     ChannelBadgesComponent,
     MindsRichEmbed,
-    TagcloudComponent,
     DropdownComponent,
     QRCodeComponent,
-
     AutoGrow,
     InlineAutoGrow,
     Emoji,
-    MindsEmoji,
     ScrollLock,
     TagsLinks,
     Tooltip,
-    MDL_DIRECTIVES,
     DateSelectorComponent,
     MindsAvatar,
     Textarea,
     InlineEditorComponent,
-
     DynamicHostDirective,
     MindsCard,
     MindsButton,
-
-    ChartComponent,
-
-    AdminActionsButtonComponent,
-
-    MaterialBoundSwitchComponent,
-
     IfFeatureDirective,
     IfBrowserDirective,
-
-    CategoriesSelectorComponent,
-    CategoriesSelectedComponent,
     TreeComponent,
-
     AnnouncementComponent,
-    MindsTokenSymbolComponent,
     PhoneInputComponent,
     PhoneInputCountryComponent,
     SafeToggleComponent,
     ThumbsUpButton,
     ThumbsDownButton,
-    DismissableNoticeComponent,
-    AnalyticsImpressions,
-    LineGraph,
-    PieGraph,
     GraphSVG,
     GraphPoints,
     DynamicFormComponent,
     AndroidAppDownloadComponent,
     SortSelectorComponent,
-    ChannelModeSelectorComponent,
     NSFWSelectorComponent,
-
-    SwitchComponent,
-
     FeaturedContentComponent,
     AttachmentPasteDirective,
-    PosterDateSelectorComponent,
     DraggableListComponent,
     ToggleComponent,
-    SidebarMenuComponent,
-    PageLayoutComponent,
     DashboardLayoutComponent,
     ShadowboxLayoutComponent,
     ShadowboxHeaderComponent,
     DropdownSelectorComponent,
-    FormDescriptorComponent,
     FormToastComponent,
     ButtonComponent,
     ShadowboxHeaderTabsComponent,
     TimespanFilterComponent,
-    EmailConfirmationComponent,
     DateDropdownsComponent,
     PhoneInputV2Component,
     PhoneInputCountryV2Component,
@@ -379,103 +313,65 @@ const routes: Routes = [
   ],
   exports: [
     MINDS_PIPES,
-
-    TopbarComponent,
+    MDL_DIRECTIVES,
     SidebarNavigationComponent,
-    TopbarOptionsComponent,
     TopbarWalletBalance,
-
-    // V3 Layout
     V3TopbarComponent,
     UserMenuV3Component,
-
-    //
-
     TooltipComponent,
     QualityScoreComponent,
     SizeableLoadingSpinnerComponent,
     FooterComponent,
     InfiniteScroll,
-    HorizontalInfiniteScroll,
     CountryInputComponent,
-    DateInputComponent,
     CityFinderComponent,
-    StateInputComponent,
     Scheduler,
     Modal,
     ReadMoreDirective,
     ReadMoreButtonComponent,
     ChannelBadgesComponent,
     MindsRichEmbed,
-    TagcloudComponent,
     DropdownComponent,
     QRCodeComponent,
-
     AutoGrow,
     InlineAutoGrow,
-    MindsEmoji,
     Emoji,
     ScrollLock,
     TagsLinks,
     Tooltip,
-    MDL_DIRECTIVES,
     DateSelectorComponent,
     MindsAvatar,
     Textarea,
     InlineEditorComponent,
-
     DynamicHostDirective,
     MindsCard,
     MindsButton,
-
-    ChartComponent,
-
-    AdminActionsButtonComponent,
-
-    MaterialBoundSwitchComponent,
-
     IfFeatureDirective,
     IfBrowserDirective,
-
-    CategoriesSelectorComponent,
-    CategoriesSelectedComponent,
     TreeComponent,
-
     AnnouncementComponent,
-    MindsTokenSymbolComponent,
     PhoneInputComponent,
     SafeToggleComponent,
     ThumbsUpButton,
     ThumbsDownButton,
-    DismissableNoticeComponent,
-    AnalyticsImpressions,
     GraphSVG,
     GraphPoints,
-    LineGraph,
-    PieGraph,
     DynamicFormComponent,
     AndroidAppDownloadComponent,
     SortSelectorComponent,
-    SwitchComponent,
     NSFWSelectorComponent,
     FeaturedContentComponent,
     AttachmentPasteDirective,
-    PosterDateSelectorComponent,
-    ChannelModeSelectorComponent,
     DraggableListComponent,
     ToggleComponent,
-    SidebarMenuComponent,
-    PageLayoutComponent,
     DashboardLayoutComponent,
     ShadowboxLayoutComponent,
     DropdownSelectorComponent,
-    FormDescriptorComponent,
     FormToastComponent,
     ButtonComponent,
     ShadowboxHeaderComponent,
     ShadowboxHeaderTabsComponent,
     TimespanFilterComponent,
-    EmailConfirmationComponent,
     DateDropdownsComponent,
     PhoneInputV2Component,
     PhoneInputCountryV2Component,

src/app/common/components/accordion/accordion.component.ts

@@ -1,3 +1,5 @@
+//
+
 import {
   AfterContentInit,
   ChangeDetectionStrategy,
@@ -11,7 +13,8 @@ import { Subscription } from 'rxjs';
 import { AccordionPaneComponent } from './accordion-pane.component';
 
 /**
- * Accordion component. Children should be <m-accordion__pane>
+ * Vertical accordion component. Children should be <m-accordion__pane>
+ * Currently used only in channel edit modal
  */
 @Component({
   selector: 'm-accordion',