Skip to content

Commit 53d971c

Browse files
committed
Revert "Emoji picker #563"
This reverts commit 222b7fb.
1 parent fe7147f commit 53d971c

17 files changed

+446
-722
lines changed

angular.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@
8181
"node_modules/material-design-lite/dist/material.blue_grey-amber.min.css",
8282
"node_modules/plyr/dist/plyr.css",
8383
"node_modules/highlight.js/styles/github.css",
84-
"node_modules/@ctrl/ngx-emoji-mart/picker.css",
8584
"src/main.css"
8685
],
8786
"scripts": [

build/ng-bundles.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ BROWSER_PATH=${1:-dist/browser}
44
EMBED_PATH=${1:-dist/embed}
55
SERVER_PATH=${3:-dist/server}
66

7-
# Allow Node.js to use up to 6G
8-
export NODE_OPTIONS="--max_old_space_size=6144"
7+
# Allow Node.js to use up to 4G
8+
export NODE_OPTIONS="--max_old_space_size=4096"
99

1010
# Build global CSS
1111
npx gulp build.sass --deploy-url="/static/en/"

package-lock.json

Lines changed: 440 additions & 448 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
"@angular/router": "~12.1.2",
4141
"@bhayward93/ckeditor5-build-minds": "^1.1.8",
4242
"@ckeditor/ckeditor5-angular": "^2.0.2",
43-
"@ctrl/ngx-emoji-mart": "^6.1.1",
4443
"@danielmoncada/angular-datetime-picker": "^12.0.0",
4544
"@growthbook/growthbook": "^0.16.1",
4645
"@mindsorg/ngx-universal": "^2.3.0",

src/app/common/common.module.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ import { AutofocusDirective } from './directives/autofocus.directive';
197197
import { SidebarMoreComponent } from './layout/sidebar-more/sidebar-more.component';
198198
import { SidebarMoreTriggerComponent } from './layout/sidebar-more/sidebar-more-trigger/sidebar-more-trigger.component';
199199
import { TagSelectorComponent } from './components/tag-selector/tag-selector.component';
200-
import { EmojiPickerComponent } from './components/emoji-picker/emoji-picker.component';
201-
import { PickerModule } from '@ctrl/ngx-emoji-mart';
202200
import { ModalCloseButtonComponent } from './components/modal-close-button/modal-close-button.component';
203201
import { BlurhashDirective } from './directives/blurhash/blurhash.directive';
204202

@@ -216,7 +214,6 @@ const routes: Routes = [
216214
RouterModule,
217215
FormsModule,
218216
ReactiveFormsModule,
219-
PickerModule,
220217
OwlDateTimeModule,
221218
OwlNativeDateTimeModule,
222219
NgxPopperjsModule,
@@ -370,7 +367,6 @@ const routes: Routes = [
370367
SidebarMoreComponent,
371368
SidebarMoreTriggerComponent,
372369
TagSelectorComponent,
373-
EmojiPickerComponent,
374370
ModalCloseButtonComponent,
375371
BlurhashDirective,
376372
],
@@ -517,7 +513,6 @@ const routes: Routes = [
517513
SidebarMoreComponent,
518514
SidebarMoreTriggerComponent,
519515
TagSelectorComponent,
520-
EmojiPickerComponent,
521516
ModalCloseButtonComponent,
522517
BlurhashDirective,
523518
],

src/app/common/components/emoji-picker/emoji-picker.component.html

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/app/common/components/emoji-picker/emoji-picker.component.scss

Lines changed: 0 additions & 108 deletions
This file was deleted.

src/app/common/components/emoji-picker/emoji-picker.component.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/app/modules/comments/comments.component.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949

5050
.m-commentPoster__form {
5151
flex-grow: 2;
52-
max-width: calc(100% - 160px);
52+
max-width: calc(100% - 130px);
5353
margin-block-end: 0;
5454
minds-textarea {
5555
padding: 0;
@@ -86,8 +86,7 @@
8686
margin: 3px 10px 0;
8787
}
8888
.m-dropdown--v2 {
89-
margin: 0 $minds-margin;
90-
89+
margin: 0;
9190
.m-commentPoster__menuButton {
9291
i {
9392
font-size: 23px;

src/app/modules/comments/poster/poster.component.html

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
(ascendingInProgress || descendingInProgress) &&
3030
attachment.hasFile()
3131
"
32-
(keyup)="keyup($event)"
33-
(click)="updateCaretPosition()"
32+
(keyup)="getPostPreview(content)"
3433
(keypress)="keypress($event)"
3534
(keydown)="keydown($event)"
3635
[placeholder]="
@@ -61,11 +60,6 @@
6160
<!-- --------------------- -->
6261
<div class="mdl-card__actions m-commentPoster__actions">
6362
<div>
64-
<m-emojiPicker
65-
*ngIf="!isMobile()"
66-
(emojiSelect)="onEmoji($event)"
67-
></m-emojiPicker>
68-
6963
<!-- Dropdown meatball -->
7064
<div class="m-dropdown--v2">
7165
<div

src/app/modules/comments/poster/poster.component.ts

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import { BehaviorSubject, Observable, Subscription } from 'rxjs';
2727
import { AuthModalService } from '../../auth/modal/auth-modal.service';
2828
import { IsCommentingService } from './is-commenting.service';
2929
import { Router } from '@angular/router';
30-
import isMobile from '../../../helpers/is-mobile';
3130

3231
@Component({
3332
selector: 'm-comment__poster',
@@ -48,9 +47,6 @@ export class CommentPosterComponent implements OnInit, OnDestroy {
4847
> = new EventEmitter();
4948
@Output('posted') posted$: EventEmitter<any> = new EventEmitter();
5049

51-
@ViewChild('message')
52-
messageTextarea: Textarea;
53-
5450
menuOpened$: BehaviorSubject<boolean> = new BehaviorSubject(false);
5551

5652
content: string = '';
@@ -61,7 +57,6 @@ export class CommentPosterComponent implements OnInit, OnDestroy {
6157
maxLength: number = 1500;
6258
loggedInSubscription: Subscription;
6359
editing: boolean = false;
64-
caretOffset: number = 0;
6560

6661
constructor(
6762
public session: Session,
@@ -93,11 +88,6 @@ export class CommentPosterComponent implements OnInit, OnDestroy {
9388
}
9489
}
9590

96-
keyup(e: KeyboardEvent) {
97-
this.getPostPreview(this.content);
98-
this.updateCaretPosition();
99-
}
100-
10191
/**
10292
* Fires before keypress function, includes backspace event.
10393
* @param { KeyboardEvent } e - keyboard event.
@@ -254,24 +244,6 @@ export class CommentPosterComponent implements OnInit, OnDestroy {
254244
this.attachment.preview(message, this.detectChanges.bind(this));
255245
}
256246

257-
/**
258-
* sets caret position
259-
*/
260-
updateCaretPosition() {
261-
const element = this.messageTextarea?.editorControl?.nativeElement;
262-
var caretOffset = 0;
263-
264-
if (element && window.getSelection) {
265-
var range = window.getSelection().getRangeAt(0);
266-
var preCaretRange = range.cloneRange();
267-
preCaretRange.selectNodeContents(element);
268-
preCaretRange.setEnd(range.endContainer, range.endOffset);
269-
caretOffset = preCaretRange.toString().length;
270-
}
271-
272-
this.caretOffset = caretOffset;
273-
}
274-
275247
getAvatar(): Observable<string> {
276248
return this.userAvatar.src$;
277249
}
@@ -307,18 +279,6 @@ export class CommentPosterComponent implements OnInit, OnDestroy {
307279
this.detectChanges();
308280
}
309281

310-
onEmoji(emoji) {
311-
const preText = this.content.substring(0, this.caretOffset);
312-
const postText = this.content.substring(this.caretOffset);
313-
this.content = preText + emoji.native + postText;
314-
// move caret after emoji
315-
this.caretOffset += emoji.native.length;
316-
}
317-
318-
isMobile() {
319-
return isMobile();
320-
}
321-
322282
detectChanges() {
323283
this.cd.markForCheck();
324284
this.cd.detectChanges();

src/app/modules/composer/components/text-area/text-area.component.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@
4141
[disabled]="isPosting$ | async"
4242
(ngModelChange)="onMessageChange($event)"
4343
(filePaste)="filePaste.emit($event)"
44-
(click)="setSelection(messageInput)"
45-
(keyup)="setSelection(messageInput)"
4644
m-attachment-paste
4745
tabindex="0"
4846
data-cy="composer-textarea"

src/app/modules/composer/components/text-area/text-area.component.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -156,17 +156,4 @@ export class TextAreaComponent implements AfterViewInit {
156156
textareaEl.style.height = 'auto';
157157
textareaEl.style.height = `${textareaEl.scrollHeight}px`;
158158
}
159-
160-
/**
161-
* sets message input text selection
162-
* @param input textarea reference
163-
*/
164-
setSelection(input) {
165-
if (input.selectionStart || input.selectionStart == '0') {
166-
this.service.selection$.next({
167-
start: input.selectionStart,
168-
end: input.selectionEnd,
169-
});
170-
}
171-
}
172159
}

src/app/modules/composer/components/toolbar/toolbar.component.html

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,6 @@
44
[class.m-composer__toolbar--small]="isCompactMode$ | async"
55
#toolbarWrapper
66
>
7-
<m-emojiPicker
8-
*ngIf="!isMobile()"
9-
(emojiSelect)="onEmoji($event)"
10-
></m-emojiPicker>
11-
127
<m-file-upload
138
[wrapperClass]="[
149
'm-composerToolbar__item',

src/app/modules/composer/components/toolbar/toolbar.component.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,6 @@
7979
}
8080
}
8181

82-
m-emojiPicker {
83-
margin-right: $minds-margin * 2;
84-
}
85-
8682
&.m-composer__toolbar--narrow
8783
.m-composerToolbarItem__icon
8884
+ .m-composerToolbarItem__label {

0 commit comments

Comments
 (0)