Skip to content

Test delegations with rosetta-cli #12277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
ylecornec opened this issue Nov 28, 2022 · 3 comments
Closed
2 of 4 tasks

Test delegations with rosetta-cli #12277

ylecornec opened this issue Nov 28, 2022 · 3 comments

Comments

@ylecornec
Copy link
Collaborator

ylecornec commented Nov 28, 2022

@ylecornec ylecornec self-assigned this Nov 28, 2022
@ylecornec ylecornec moved this from Todo to In Progress in Rosetta-API Nov 29, 2022
@ylecornec ylecornec moved this from In Progress to Todo in Rosetta-API Nov 30, 2022
@ylecornec ylecornec moved this from Todo to In Progress in Rosetta-API Dec 5, 2022
@ylecornec ylecornec moved this from In Progress to Blocked in Rosetta-API Dec 5, 2022
@kantp kantp moved this from Blocked to In Progress in Rosetta-API Dec 9, 2022
@kantp kantp moved this from In Progress to Blocked in Rosetta-API Dec 9, 2022
@kantp kantp moved this from Blocked to In Progress in Rosetta-API Dec 13, 2022
@kantp kantp moved this from In Progress to Blocked in Rosetta-API Dec 15, 2022
@kantp kantp moved this from Blocked to In Review in Rosetta-API Dec 16, 2022
@ylecornec ylecornec assigned kantp and unassigned ylecornec Dec 16, 2022
@kantp kantp assigned Sventimir and unassigned kantp Dec 22, 2022
@robinbb
Copy link

robinbb commented Jan 11, 2023

@Sventimir this is an issue in review. Does that mean that you believe that #12373 is sufficient to close this issue? Do we really need to wait for upstream? What is the ETA on this task?

@Sventimir
Copy link
Contributor

@robinbb There's also PR ro rosetta-sdk-go, which the PR you mentioned depends on. I think we don't have to wait for Coinbase to integrate our changes, though, as we can build rosetta-cli with updated SDK for our internal testing. Actually this is what #12373 does for the moment. So I think as soon as CI issues that block merging of #12373 are fixed, we can merge and close this issue. No need to wait for the upstream indeed.

@Sventimir
Copy link
Contributor

I extracted the update our tests when our changes are accepted upstream to a separate issue: #12509.

@github-project-automation github-project-automation bot moved this from In Review to Done in Rosetta-API Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants