Merge branch 'release/v2.0.0'

Author: genaromadrid

Readme.md

@@ -58,7 +58,7 @@ Document methods:
     $document = new Document([
       'file' => 'path/to/my-file.pdf',
       // OR
-      'original_hash' => hash('sha256', 'some-file-contents'),
+      'original_hash' => hash('sha256', file_get_contents('path/to/my-file.pdf')),
       'signatories' => [
         { 
           'name' => 'Signer 1', 
@@ -78,7 +78,8 @@ Document methods:
 - Delete
 
   ```php
-    $document->delete();
+    use Mifiel\Document;
+    Document::delete('id');
   ```
 
 Certificate methods:
@@ -120,7 +121,8 @@ Certificate methods:
 - Delete
 
   ```php
-    $certificate->delete();
+    use Mifiel\Certificate;
+    Certificate::delete('id');
   ```
 
 ## Contributing

composer.json

@@ -1,7 +1,7 @@
 {
   "name": "mifiel/api-client",
   "description": "Mifiel API Client for PHP",
-  "version": "1.0.1",
+  "version": "2.0.0",
   "keywords": [
     "Firma electrónica",
     "Firma electrónica Avanzada",

src/BaseObject.php

@@ -54,10 +54,10 @@ public function save(){
     $this->values = (object) json_decode($response->getBody());
   }
 
-  public function delete(){
+  public static function delete($id){
     self::validateResuorceName();
     $response = ApiClient::delete(
-      static::$resourceName . '/' . $this->id
+      static::$resourceName . '/' . $id
     );
   }
 

tests/CertificateTest.php

@@ -87,17 +87,13 @@ public function testSetGetProperties() {
   }
 
   public function testDelete() {
-    $certificate = new Certificate([
-      'id' => 'some-id'
-    ]);
-
     m::mock('alias:Mifiel\ApiClient')
       ->shouldReceive('delete')
       ->with('keys/some-id')
       ->andReturn(new \GuzzleHttp\Psr7\Response)
       ->once();
 
-    $certificate->delete();
+    Certificate::delete('some-id');
   }
 
   public function testSat() {

tests/DocumentTest.php

@@ -88,17 +88,13 @@ public function testSetGetProperties() {
   }
 
   public function testDelete() {
-    $document = new Document([
-      'id' => 'some-id'
-    ]);
-
     m::mock('alias:Mifiel\ApiClient')
       ->shouldReceive('delete')
       ->with('documents/some-id')
       ->andReturn(new \GuzzleHttp\Psr7\Response)
       ->once();
 
-    $document->delete();
+    Document::delete('some-id');
   }
 
 }

tests/integration/CertificateCRUDTest.php

@@ -65,7 +65,7 @@ public function testSetProperties() {
   public function testDelete() {
     $certificate = $this->getCertificate();
     if ($certificate)
-      $certificate->delete();
+      Certificate::delete($certificate->id);
     $certificates = Certificate::all();
     $this->assertEmpty($certificates);
   }

tests/integration/DocumentCRUDTest.php

@@ -98,7 +98,7 @@ public function testSetProperties() {
   public function testDelete() {
     $documents = Document::all();
     foreach ($documents as $document) {
-      $document->delete();
+      Document::delete($document->id);
     }
     $documents = Document::all();
     $this->assertEmpty($documents);