Skip to content

Commit f10bf62

Browse files
committed
cleanup
1 parent c4f4779 commit f10bf62

File tree

3 files changed

+34
-35
lines changed

3 files changed

+34
-35
lines changed

app/components/UI/Perps/Views/PerpsClosePositionView/PerpsClosePositionView.test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
defaultPerpsClosePositionValidationMock,
1414
defaultPerpsEventTrackingMock,
1515
defaultPerpsLivePricesMock,
16-
defaultPerpsOrderBookMock,
16+
defaultPerpsTopOfBookMock,
1717
defaultPerpsOrderFeesMock,
1818
defaultPerpsPositionMock,
1919
defaultPerpsRewardsMock,
@@ -52,7 +52,7 @@ jest.mock('../../hooks', () => ({
5252

5353
jest.mock('../../hooks/stream', () => ({
5454
usePerpsLivePrices: jest.fn(),
55-
usePerpsOrderBook: jest.fn(),
55+
usePerpsTopOfBook: jest.fn(),
5656
}));
5757

5858
jest.mock('../../hooks/usePerpsEventTracking', () => ({
@@ -122,8 +122,8 @@ describe('PerpsClosePositionView', () => {
122122
const usePerpsLivePricesMock = jest.mocked(
123123
jest.requireMock('../../hooks/stream').usePerpsLivePrices,
124124
);
125-
const usePerpsOrderBookMock = jest.mocked(
126-
jest.requireMock('../../hooks/stream').usePerpsOrderBook,
125+
const usePerpsTopOfBookMock = jest.mocked(
126+
jest.requireMock('../../hooks/stream').usePerpsTopOfBook,
127127
);
128128
const usePerpsOrderFeesMock = jest.mocked(
129129
jest.requireMock('../../hooks').usePerpsOrderFees,
@@ -167,7 +167,7 @@ describe('PerpsClosePositionView', () => {
167167

168168
// Setup hook mocks with default values
169169
usePerpsLivePricesMock.mockReturnValue(defaultPerpsLivePricesMock);
170-
usePerpsOrderBookMock.mockReturnValue(defaultPerpsOrderBookMock);
170+
usePerpsTopOfBookMock.mockReturnValue(defaultPerpsTopOfBookMock);
171171
usePerpsOrderFeesMock.mockReturnValue(defaultPerpsOrderFeesMock);
172172
usePerpsClosePositionValidationMock.mockReturnValue(
173173
defaultPerpsClosePositionValidationMock,

app/components/UI/Perps/Views/PerpsOrderView/PerpsOrderView.test.tsx

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -571,26 +571,23 @@ const createMockStreamManager = () => {
571571
account: {
572572
subscribe: jest.fn(() => jest.fn()),
573573
},
574-
orderBooks: {
575-
subscribeToSymbols: ({
576-
symbols,
574+
topOfBook: {
575+
subscribeToSymbol: ({
576+
symbol: _symbol,
577577
callback,
578578
}: {
579-
symbols: string[];
579+
symbol: string;
580580
callback: (data: unknown) => void;
581581
}) => {
582582
const id = Math.random().toString();
583583
subscribers.set(id, callback);
584-
// Immediately provide mock order book data
585-
const mockOrderBooks: Record<string, unknown> = {};
586-
symbols.forEach((symbol: string) => {
587-
mockOrderBooks[symbol] = {
588-
bestBid: '2999',
589-
bestAsk: '3001',
590-
spread: '2',
591-
};
592-
});
593-
callback(mockOrderBooks);
584+
// Immediately provide mock top of book data
585+
const mockTopOfBook = {
586+
bestBid: '2999',
587+
bestAsk: '3001',
588+
spread: '2',
589+
};
590+
callback(mockTopOfBook);
594591
return () => {
595592
subscribers.delete(id);
596593
};

app/components/UI/Perps/providers/PerpsStreamManager.test.tsx

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,12 +1414,12 @@ describe('PerpsStreamManager', () => {
14141414
});
14151415
});
14161416

1417-
describe('OrderBookStreamChannel', () => {
1418-
it('subscribes to order books with includeOrderBook flag', () => {
1417+
describe('TopOfBookStreamChannel', () => {
1418+
it('subscribes to top of book with includeOrderBook flag', () => {
14191419
const callback = jest.fn();
14201420

1421-
testStreamManager.orderBooks.subscribeToSymbols({
1422-
symbols: ['BTC'],
1421+
testStreamManager.topOfBook.subscribeToSymbol({
1422+
symbol: 'BTC',
14231423
callback,
14241424
});
14251425

@@ -1430,11 +1430,11 @@ describe('PerpsStreamManager', () => {
14301430
});
14311431
});
14321432

1433-
it('filters order books to requested symbols', () => {
1433+
it('provides top of book data for subscribed symbol', () => {
14341434
const callback = jest.fn();
14351435

1436-
testStreamManager.orderBooks.subscribeToSymbols({
1437-
symbols: ['BTC'],
1436+
testStreamManager.topOfBook.subscribeToSymbol({
1437+
symbol: 'BTC',
14381438
callback,
14391439
});
14401440

@@ -1445,35 +1445,37 @@ describe('PerpsStreamManager', () => {
14451445
]);
14461446

14471447
expect(callback).toHaveBeenCalledWith({
1448-
BTC: { bestBid: '50000', bestAsk: '50001', spread: undefined },
1448+
bestBid: '50000',
1449+
bestAsk: '50001',
1450+
spread: undefined,
14491451
});
14501452
});
14511453

1452-
it('does not subscribe when symbols array is empty', () => {
1454+
it('does not subscribe when symbol is empty', () => {
14531455
const callback = jest.fn();
14541456

1455-
testStreamManager.orderBooks.subscribeToSymbols({
1456-
symbols: [],
1457+
testStreamManager.topOfBook.subscribeToSymbol({
1458+
symbol: '',
14571459
callback,
14581460
});
14591461

14601462
expect(mockSubscribeToPrices).not.toHaveBeenCalled();
14611463
});
14621464

1463-
it('clears order book cache when clearCache called', () => {
1465+
it('clears top of book cache when clearCache called', () => {
14641466
const callback = jest.fn();
14651467

1466-
testStreamManager.orderBooks.subscribeToSymbols({
1467-
symbols: ['BTC'],
1468+
testStreamManager.topOfBook.subscribeToSymbol({
1469+
symbol: 'BTC',
14681470
callback,
14691471
});
14701472

14711473
const priceCallback = mockSubscribeToPrices.mock.calls[0][0].callback;
14721474
priceCallback([{ coin: 'BTC', bestBid: '50000', bestAsk: '50001' }]);
14731475

1474-
testStreamManager.orderBooks.clearCache();
1476+
testStreamManager.topOfBook.clearCache();
14751477

1476-
expect(callback).toHaveBeenCalledWith({});
1478+
expect(callback).toHaveBeenCalledWith(undefined);
14771479
});
14781480
});
14791481
});

0 commit comments

Comments
 (0)