fixed ArgumentOutOfRange in Acyclic property check

Author: MaxRev-Dev

BinaryRelations/Binary/Properties.cs

@@ -245,10 +245,13 @@ public static bool IsAcyclic(this bool[,] matrix1)
         {
             ThrowIfNull_NotQuad(matrix1);
             var node = 0;
+            var lastNode = matrix1.GetLength(1) - 1;
             var children = GetConnectedEdges(matrix1, node).ToArray();
-            while (!children.Any() || node != matrix1.GetLength(1) - 1)
+            while (!children.Any())
             {
-                children = GetConnectedEdges(matrix1, ++node).ToArray();
+                if (node >= lastNode) 
+                    break;
+                children = GetConnectedEdges(matrix1, node++).ToArray();
             }
             return !HasCycle(matrix1, node, new HashSet<int>());
         }
@@ -259,13 +262,8 @@ private static bool HasCycle(in bool[,] matrix1, int node, in HashSet<int> path)
                 return true;
             var current = new HashSet<int>(path) { node };
 
-            foreach (var child in GetConnectedEdges(matrix1, node))
-            {
-                if (HasCycle(matrix1, child, current))
-                    return true;
-            }
-
-            return false;
+            var shade = matrix1;
+            return GetConnectedEdges(matrix1, node).Any(child => HasCycle(shade, child, current));
         }
 
         /// <summary>

BinaryRelationsTests/PropertiesTests.cs

@@ -136,6 +136,14 @@ public void IsAntiSymmetric()
         public void IsAcyclic()
         {
             var m = new[,]
+            {
+                {0, 1, 0},
+                {0, 0, 1},
+                {0, 0, 0}
+            }.Cast<int, bool>();
+            Assert.True(m.IsAcyclic());
+
+            m = new[,]
             {
                 {0, 1, 0, 0},
                 {0, 0, 0, 1},