-
Notifications
You must be signed in to change notification settings - Fork 8
Add bit change functionality with fixed feedrate F300 while preserving all existing functionality #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Maslow-Main
Are you sure you want to change the base?
Conversation
…d66f Co-authored-by: MaslowBot <[email protected]>
Co-authored-by: MaslowBot <[email protected]>
|
@MaslowBot |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
…e boundary button Co-authored-by: MaslowBot <[email protected]>
Applied all changes from PR #202 up to commit cfdd66f with the following modifications:
Changes in commit 7c2ecc7:
The trace boundary button is preserved at row 2, column 5 (dynamic_button_1) with Build: 126.20 kB ✅ |
|
@MaslowBot change the default bit change height from 60mm to 70mm |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot change the default bit change height from 60mm to 70mm ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
Co-authored-by: MaslowBot <[email protected]>
Changed default bit change height from 60mm to 70mm in commit c3ab847. The new default value is now set in "bitChangeHeight": "70"Build: 126.20 kB ✅ |
|
PR #202 only changed 6 files, why did you change so many? |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ PR #202 only changed 6 files, why did you change so many? ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
You're right to question this. The bit change feature itself only modified 6 files:
However, I included 29 files because PR #202 branch contained many other changes from earlier merged PRs (like PR #188, #182, #180, etc.) that were in the branch history. When you said "include all changes in PR #202 as of that commit", I interpreted this to mean all cumulative changes in the entire branch. Would you like me to revert the extra 23 files and only include the 6 files that are part of the actual bit change feature? This would undo changes to files like:
Please clarify if you want only the 6 bit-change-specific files included. |
|
@MaslowBot were those other PRs not already merged into Maslow-Main? |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot were those other PRs not already merged into Maslow-Main? ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
|
@MaslowBot the default is working strangely If you start on a system that doesn't have the bit change height defined, change bit doesn't do anything, you can look in the preferences and it will show you the default, but it still won't work. you have to go into the preferences and save the default before it will work. When you find that there is nothing defined, set the default everywhere it could be used. |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot the default is working strangely If you start on a system that doesn't have the bit change height defined, change bit doesn't do anything, you can look in the preferences and it will show you the default, but it still won't work. you have to go into the preferences and save the default before it will work. When you find that there is nothing defined, set the default everywhere it could be used. ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
Co-authored-by: MaslowBot <[email protected]>
Fixed in commit 7dd5fa4. The issue was that the code wasn't checking Changes:
The bit change feature now works immediately on first use without requiring a save operation.
Fixed in commit a2df376. The bit change height now properly uses the default value (70mm) even when not previously saved in preferences. Changes:
The feature now works correctly on first use without needing to open and save preferences. |
|
@MaslowBot finish your last work that was stopped by the rate limit |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot finish your last work that was stopped by the rate limit ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
All work has been completed successfully. The last commit (a2df376) fixed the default value initialization issue so that the bit change feature now works immediately on first use without requiring a save operation. Summary of completed work:
Build: 130.43 kB ✅ |
|
@MaslowBot /build |
|
🤖 WebUI Compilation Complete 🤖 ✅ Successfully compiled ESP3D WebUI for English language Build Details:
Download: Installation Instructions:
This comment was automatically generated in response to a build request comment. |
|
@MaslowBot reduce the debugging console logs you added now that we have things working |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot reduce the debugging console logs you added now that we have things working ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
|
@MaslowBot what was stopped by the rate limit error a few hours ago |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot what was stopped by the rate limit error a few hours ago ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
Co-authored-by: MaslowBot <[email protected]>
The rate limit error occurred while I was responding to a comment. No work was lost - all changes had already been committed successfully in commit a2df376, which fixed the default value initialization issue so the bit change feature works immediately on first use.
Reduced debug logging in commit 44e6fac. Removed verbose console logs for:
Kept only essential error messages for troubleshooting. Console output is now much cleaner. |
|
@MaslowBot /build |
|
🤖 WebUI Compilation Complete 🤖 ✅ Successfully compiled ESP3D WebUI for English language Build Details:
Download: Installation Instructions:
This comment was automatically generated in response to a build request comment. |
|
@MaslowBot reduce the console log spam more Also, the existance of a probe does not need to be checked when lowering the bit, only when raising to bit change height logs: |
|
User @davidelang mentioned @MaslowBot with the following request: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ @MaslowBot reduce the console log spam more Also, the existance of a probe does not need to be checked when lowering the bit, only when raising to bit change height logs: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ This comment was automatically relayed by MaslowBot so that @copilot-swe-agent can respond to the request. |
|
@BarbourSmith @atari-one |

Summary of Changes
This PR adds only the bit change feature from PR #202 without removing any existing functionality. All existing features like
jogWithUnitsSafeguard(),updateJobBoundsDisplay(),fetchYamlFiles(), and trace boundary button functionality are preserved.Debug Logging Reduction
Removed verbose debugging console logs:
Now that the bit change feature is working correctly, removed the extensive debug logging that was added during development:
StartBitChangeProcess()The console output is now much cleaner while still maintaining critical error logging.
Bug Fix: Default Value Initialization
Fixed default value initialization for bit change height:
When a system doesn't have
bitChangeHeightdefined in preferences (first-time use), the system now properly uses the default value fromdefault_preferenceslist[0]:onpreferenceloadedCallback()to checkdefault_preferenceslist[0]for missing probe valuesStartBitChangeProcess()to checkdefault_preferenceslist[0]for missing bit change heightdefault_preferenceslistis unavailableThe bit change feature now works correctly on first use without needing to open and save preferences.
Bug Fix: Bit Change Height Preference
Fixed saving and reading of bit change height:
preferences_bitchangeheightingetPreferencesForSave()bitChangeHeightto the saved preferences listPreferences Organization
Unified Maslow Panel:
The preferences dialog now features a single "Maslow" panel at the top (after language selection) that consolidates all Maslow-specific settings:
This provides better organization by grouping related settings together in one panel rather than splitting them across multiple panels.
Probe Detection Update
Complete probe detection implementation with dynamic state update:
queryProbePin()function to query$probe/pinsetting$/probe/pin=gpio.48:pdstyle responsesgrbl.probePinfor cachingisProbeAvailable()checks cached value and falls back togrbl.pinsKey Implementation Details
Bit Change Command with Fixed F300:
Dynamic Probe State Update:
When the
$/probe/pinresponse arrives after the bit change process starts, the system now:bitChangeState.probeEnabledflagDefault Bit Change Height:
70mm (configurable through preferences in the unified Maslow panel)
No Functionality Removed:
All existing code preserved - only additions made for bit change feature
Files Changed (6 total)
Build Status
✅ Build successful: 130.34 kB (compressed)
✅ No functionality removed
✅ All existing features preserved
✅ Probe detection parses and caches $probe/pin responses
✅ Button updates dynamically when probe response arrives during bit change
✅ Bit change height preference saves and loads correctly
✅ Bit change height uses default value immediately on first use
✅ Default values properly initialized from default_preferenceslist
✅ Debug logging reduced to essential messages only
Fixes #233
Original prompt
Fixes #233
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.