#608: processed review comments

Author: petermasking

packages/health/src/HealthManager.ts

@@ -30,7 +30,7 @@ export default class HealthManager
 
     async stop(): Promise<void>
     {
-        return this.#clearHealthChecks();
+        return this.clearHealthChecks();
     }
 
     async loadHealthCheck(filename: string): Promise<void>
@@ -96,11 +96,6 @@ export default class HealthManager
         await Promise.all(this.#healthCheckFiles.map(filename => this.loadHealthCheck(filename)));
     }
 
-    #clearHealthChecks(): void
-    {
-        this.#healthChecks.clear();
-    }
-
     #handleHealthCheckResult(result: PromiseSettledResult<HealthCheckResult>, healthChecks: Map<string, boolean>): void
     {
         if (result.status !== 'fulfilled')

packages/middleware/src/MiddlewareManager.ts

@@ -26,7 +26,7 @@ export default class MiddlewareManager
 
     async stop(): Promise<void>
     {
-        return this.#clearMiddlewares();
+        return this.clearMiddlewares();
     }
 
     async loadMiddleware(filename:string): Promise<void>
@@ -70,11 +70,6 @@ export default class MiddlewareManager
         await Promise.all(this.#middlewareFiles.map(filename => this.loadMiddleware(filename)));
     }
 
-    #clearMiddlewares(): void
-    {
-        this.#middlewares.slice();
-    }
-
     #getNextHandler(request: Request, index: number): NextHandler
     {
         const next = this.#middlewares[index];

packages/runtime/src/server/ServerBuilder.ts

@@ -156,7 +156,7 @@ export default class RuntimeBuilder
         return new MiddlewareManager(this.#sourcingManager, translatedFilenames);
     }
 
-    #buildExecutionManager(segmentNames: string[]): ExecutionManager
+    #buildExecutionManager(segmentNames: string[] = []): ExecutionManager
     {
         const filenames = segmentNames.map(name => `./${name}.segment.js`);
 

packages/services/test/repository/fixtures/sourcingManager.fixture.ts

@@ -34,12 +34,6 @@ class DummySourcingManager extends LocalSourcingManager
     {
         throw new NotImplemented();
     }
-
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    import(filename: string): Promise<Module>
-    {
-        throw new NotImplemented();
-    }
 }
 
 export const sourcingManager = new DummySourcingManager('');

packages/sourcing/src/modules/RemoteImportManager.ts

@@ -2,7 +2,7 @@
 import ImportManager from './ImportManager';
 import RemoteModuleLocator from './RemoteModuleLocator';
 
-export default class LocalImportManager extends ImportManager
+export default class RemoteImportManager extends ImportManager
 {
     constructor(location: string)
     {