#608: processed more Snyk and CodeRabbit feedback

Author: petermasking

packages/runtime/src/server/ServerBuilder.ts

@@ -95,7 +95,7 @@ export default class RuntimeBuilder
     {
         const trustKey = configuration.trustKey;
         const gateway = configuration.gateway ? this.#buildRemoteGateway(configuration.gateway) : undefined;
-        const registerAtGateway = gateway !== undefined;
+        const registerAtGateway = gateway !== undefined; // if we have a gateway, the worker needs to register itself at it.
         const executionManager = this.#buildExecutionManager(configuration.segments);
 
         return new LocalWorker({ url, trustKey, gateway, registerAtGateway, executionManager });

packages/services/test/repository/fixtures/sourcingManager.fixture.ts

@@ -1,6 +1,6 @@
 
 import { NotImplemented } from '@jitar/errors';
-import { File, FileNotFound, Module, LocalSourcingManager } from '@jitar/sourcing';
+import { File, FileNotFound, LocalSourcingManager } from '@jitar/sourcing';
 
 import { FILENAMES } from './filenames.fixture';
 import { FILES } from './files.fixtures';

packages/sourcing/src/files/LocalFileSystem.ts

@@ -74,7 +74,14 @@ export default class LocalFileSystem implements FileSystem
 
     async mimeType(location: string): Promise<string | undefined>
     {
-        return mime.lookup(location) || undefined;
+        const mimeType = mime.lookup(location);
+
+        if (mimeType === false)
+        {
+            return undefined;
+        }
+
+        return mimeType;
     }
 
     async write(location: string, content: string): Promise<void>

packages/sourcing/src/modules/ImportManager.ts

@@ -6,7 +6,7 @@ import Module from './types/Module';
 
 export default class ImportManager implements ModuleImporter
 {
-    #moduleLocator: ModuleLocator;
+    readonly #moduleLocator: ModuleLocator;
 
     constructor(moduleLocator: ModuleLocator)
     {

packages/sourcing/src/modules/RemoteImportManager.ts

@@ -4,6 +4,7 @@ import RemoteModuleLocator from './RemoteModuleLocator';
 
 export default class RemoteImportManager extends ImportManager
 {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     constructor(location: string)
     {
         super(new RemoteModuleLocator(location));

packages/sourcing/src/modules/RemoteModuleLocator.ts

@@ -4,11 +4,15 @@ import ModuleLocator from './interfaces/ModuleLocator';
 
 export default class RemoteModuleLocator implements ModuleLocator
 {
+    // This is a placeholder class because remote module loading
+    // is currently not allowed due to security reasons.
+
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     constructor(location: string)
     {
         // This constructor is intentionally empty.
-        // Remote module loading is currently not allowed due to security reasons.
+        // In case we ever want to allow remote module loading,
+        // we need the location to be passed in.
     }
 
     locate(filename: string): string