gdb server timeout is now 60 seconds with feedback every 5

Author: haneefdm

CHANGELOG.md

@@ -1,5 +1,11 @@
 # ChangeLog
 
+# V1.13.0-pre7
+* Added `overridePreEndSessionCommands` to control how a session ends. If the session does not end your way, we sill end the session the normal way
+* We try `monitor exit` to exit the server before we try `target-disconnect` for those servers that do not follow the GDB rules
+* During GDB server startup, the timeout is now 60 seconds but every 5 seconds, you will some feedback in the debug console that we are stil waiting
+* Added preliminary support for HW/SW breakpoints. There are still issues with GDB not counting HW breakpoints correctly.
+
 # V1.13.0-pre6
 * Make the advanced decoder work properly for RTT. It now allows a dispose.
 * Both SWO/RTT OUTPUT panels are now recycled instead of creating a new one every time. You can for a new one by supplying a new outputLabel and/or typeName.

debug_attributes.md

@@ -51,6 +51,7 @@ If the type is marked as `{...}` it means that it is a complex item can have mul
 | overrideAttachCommands | string[] | Attach | Override the commands that are normally executed as part of attaching to a running target. In most cases it is preferable to use preAttachCommands and postAttachCommands to customize the GDB attach sequence. |
 | overrideGDBServerStartedRegex | string | Both | You can supply a regular expression (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions) in the configuration property to override the output from the GDB Server that is looked for to determine if the GDB Server has started. Under most circumstances this will not be necessary - but could be needed as a result of a change in the output of a GDB Server making it incompatible with cortex-debug. This property has no effect for bmp or external GDB Server types. |
 | overrideLaunchCommands | string[] | Launch | Override the commands that are normally executed as part of flashing and launching the target. In most cases it is preferable to use preLaunchCommands and postLaunchCommands to customize the GDB launch sequence. |
+| overridePreEndSessionCommands | string[] | Both | Override the commands that are normally executed at the start of ending a debug session (e.g. when stopping debugging). |
 | overrideResetCommands | string[] | Both | Override the commands that are normally executed as part of reset-ing the target. When undefined the deprecated overrideRestartCommands is used if it exists. |
 | postAttachCommands | string[] | Attach | Additional GDB Commands to be executed after the main attach sequence has finished. |
 | postLaunchCommands | string[] | Launch | Additional GDB Commands to be executed after the main launch sequence has finished. |

src/backend/server.ts

@@ -36,7 +36,7 @@ export class GDBServer extends EventEmitter {
     protected consoleSocket: net.Socket = null;
     private initResolve: (result: boolean) => void;
     private initReject: (error: any) => void;
-    public static readonly SERVER_TIMEOUT = 10000;
+    public static readonly SERVER_TIMEOUT = 60 * 1000;
     public static readonly LOCALHOST = '0.0.0.0';
     public pid: number = -1;
 

src/gdb.ts

@@ -599,6 +599,16 @@ export class GDBDebugSession extends LoggingDebugSession {
             });
             this.usingParentServer = this.args.pvtMyConfigFromParent && !this.args.pvtMyConfigFromParent.detached;
             this.getTCPPorts(this.usingParentServer).then(async () => {
+                function clearTimers() {
+                    if (timeout) {
+                        clearTimeout(timeout);
+                        timeout = null;
+                    }
+                    if (feedbackTimer) {
+                        clearInterval(feedbackTimer);
+                        feedbackTimer = null;
+                    }
+                }
                 await this.serverController.allocateRTTPorts();     // Must be done before serverArguments()
                 const executable = this.usingParentServer ? null : this.serverController.serverExecutable();
                 const args = this.usingParentServer ? [] : this.serverController.serverArguments();
@@ -655,12 +665,16 @@ export class GDBDebugSession extends LoggingDebugSession {
                     doResolve();
                 }, GDBServer.SERVER_TIMEOUT);
 
+                let elapsed = 0;
+                let feedbackTimer = setInterval(() => {
+                    const svrName = this.serverController.name || this.args.servertype;
+                    elapsed += 5;
+                    this.handleMsg('stdout', `Still waiting for ${svrName} GDB Server to be ready, ${elapsed} seconds...\n`);
+                }, 5 * 1000);
+
                 this.serverController.serverLaunchStarted();
                 this.server.init().then(async (started) => {
-                    if (timeout) {
-                        clearTimeout(timeout);
-                        timeout = null;
-                    }
+                    clearTimers();
                     const commands = [];
                     try {
                         // This is where 4 things meet and they must all finish (in any order) before we can proceed
@@ -773,10 +787,7 @@ export class GDBDebugSession extends LoggingDebugSession {
                         }
                     });
                 }, (error) => {
-                    if (timeout) {
-                        clearTimeout(timeout);
-                        timeout = null;
-                    }
+                    clearTimers
                     this.sendEvent(new TelemetryEvent(
                         'Error',
                         'Launching Server',