ForCtorParam should be inherited

[ruben-ivre]

When using records (or a class with a constructor), when you define ForCtorParam in a base class, you also need to specify it in every derived class again. I understand that derived classes could have less or more constructor parameters, but I think it's a safe assumption to reuse the same constructor param mapping as the base class if the name and type of the parameter matches.
Otherwise, this makes using inheritance with constructors quite cumbersome, as I have to repeat the same mappings over and over.

Source/destination types

public record class SourceBase(bool IsPublic) {}
public record class SourceDerived(bool IsPublic) : SourceBase(IsPublic) {}

public record class TargetBase(string Visibility) {}
public record class TargetDerived(string Visibility) : TargetBase(Visibility) {}

Mapping configuration

CreateMap<SourceBase, TargetBase>()
	.ForCtorParam(nameof(TargetBase.Visibility), o => o.MapFrom(s => s.IsPublic ? "public" : "private"))
	.IncludeAllDerived();
CreateMap<SourceDerived, TargetDerived>();

Version: 12.0.1

Expected behavior

Above configuration should be valid, understanding the the same mapping done in the base class for the Visibility parameter can be reused again in the derived type.

Actual behavior

Above configuration fails the validation, force me to repeat the ForCtorParam in the base class in each of the derived ones.

Steps to reproduce

https://dotnetfiddle.net/i8nhRQ

var config = new MapperConfiguration(cfg =>
{
    cfg.AddProfile<TestProfile>();
});
config.AssertConfigurationIsValid();
var mapper = config.CreateMapper();
var result = mapper.Map<TargetDerived>(new SourceDerived(true));
Console.WriteLine(result.Visibility);

[lbargaoanu]

A PR is welcome.

[rubengonzalezlodeiro]

Yes, just ignoring non-public constructors fixed the test, without additional code changes.
I've made a PR with my changes, let me know if it's ok. #4314

[lbargaoanu]

Too complicated. Check my link about IncludeMembers. I expect a similar implementation. So some of your code, but closer to that one.

[rubengonzalezlodeiro]

Original method was based on TypeMapConfiguration.MapDestinationCtorToSource, looking through all constructors to find one that is solvable now with the inheritance applied, but I've changed it now to be more like ApplyIncludedMember, as you suggested.
I've updated the PR for your review.

[lbargaoanu]

Yes, but I think having multiple constructors and mapping inheritance is kind of complicated. So such a case should probably be handled explicitly. It would take a bigger change in AM to handle it by choosing the constructor only once and I don't think it's worth the extra complexity.

[rubengonzalezlodeiro]

PR updated and fixed the mappings that weren't truly working before.

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed.