Skip to content

Commit 57a2948

Browse files
committed
rfbserver: don't log other clients on client connect
A server program can always find out about connected clients itself, no need to log them for informative purposes. What's more, this led to a potentially dangerous log file size escalation when many clients were connected.
1 parent 2935d1f commit 57a2948

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

libvncserver/rfbserver.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -354,13 +354,6 @@ rfbNewTCPOrUDPClient(rfbScreenInfoPtr rfbScreen,
354354
cl->host = strdup(inet_ntoa(addr.sin_addr));
355355
#endif
356356

357-
rfbLog(" other clients:\n");
358-
iterator = rfbGetClientIterator(rfbScreen);
359-
while ((cl_ = rfbClientIteratorNext(iterator)) != NULL) {
360-
rfbLog(" %s\n",cl_->host);
361-
}
362-
rfbReleaseClientIterator(iterator);
363-
364357
if(!rfbSetNonBlocking(sock)) {
365358
close(sock);
366359
return NULL;

0 commit comments

Comments
 (0)