refactor: Change storage to Concurrent Stack for thread safety

RobynLlama · RobynLlama · commit 5159788a07fc · 2024-08-23T20:06:35.000-05:00
diff --git a/src/UnityDebuggerAssistant/Patches/Exception.cs b/src/UnityDebuggerAssistant/Patches/Exception.cs
@@ -3,13 +3,14 @@
 using System.Collections.Generic;
 using HarmonyLib;
 using UnityDebuggerAssistant.Utils;
+using System.Collections.Concurrent;
 
 namespace UnityDebuggerAssistant.Patches;
 [HarmonyPatch]
 public static class ExceptionConstructorPatch
 {
 
-    internal static readonly List<Exception> Storage = [];
+    internal static readonly ConcurrentStack<Exception> Storage = [];
 
     static IEnumerable<MethodBase> TargetMethods()
     {
@@ -18,10 +19,7 @@ static IEnumerable<MethodBase> TargetMethods()
 
     static void Postfix(Exception __instance)
     {
-        if (Storage.Contains(__instance))
-            return;
-
-        Storage.Add(__instance);
+        Storage.Push(__instance);
     }
 }
 internal static class ExceptionProcessor

Original file line number	Diff line number	Diff line change
`@@ -3,13 +3,14 @@`
`3`	`3`	`using System.Collections.Generic;`
`4`	`4`	`using HarmonyLib;`
`5`	`5`	`using UnityDebuggerAssistant.Utils;`
	`6`	`+using System.Collections.Concurrent;`
`6`	`7`
`7`	`8`	`namespace UnityDebuggerAssistant.Patches;`
`8`	`9`	`[HarmonyPatch]`
`9`	`10`	`public static class ExceptionConstructorPatch`
`10`	`11`	`{`
`11`	`12`
`12`		`- internal static readonly List<Exception> Storage = [];`
	`13`	`+ internal static readonly ConcurrentStack<Exception> Storage = [];`
`13`	`14`
`14`	`15`	`static IEnumerable<MethodBase> TargetMethods()`
`15`	`16`	`{`
`@@ -18,10 +19,7 @@ static IEnumerable<MethodBase> TargetMethods()`
`18`	`19`
`19`	`20`	`static void Postfix(Exception __instance)`
`20`	`21`	`{`
`21`		`- if (Storage.Contains(__instance))`
`22`		`- return;`
`23`		`-`
`24`		`- Storage.Add(__instance);`
	`22`	`+ Storage.Push(__instance);`
`25`	`23`	`}`
`26`	`24`	`}`
`27`	`25`	`internal static class ExceptionProcessor`