Skip to content

Extension - Improvements unified account after Bitcoin supported #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
ThaoNguyen998 opened this issue Mar 10, 2025 · 6 comments · Fixed by #4276
Closed
2 tasks done

Extension - Improvements unified account after Bitcoin supported #4094

ThaoNguyen998 opened this issue Mar 10, 2025 · 6 comments · Fixed by #4276
Assignees
Milestone

Comments

@ThaoNguyen998
Copy link

ThaoNguyen998 commented Mar 10, 2025

Describe the task

@ThaoNguyen998 ThaoNguyen998 added this to the Milestone 8 milestone Mar 10, 2025
@Sokol142196 Sokol142196 changed the title Extension - Improvements allow unified account export private key for compatibility with other wallets Extension - Improvements unified account after Bitcoin supported Mar 31, 2025
@hieudd hieudd modified the milestones: Milestone 8, Milestone 09 Apr 1, 2025
@hieudd hieudd assigned lw-cdm and dungnguyen-art and unassigned lw-cdm Apr 14, 2025
@haiyenvu23
Copy link

haiyenvu23 commented Apr 16, 2025

Version test: https://file.cdmteck.com/s/g7j6twSrkydA2zN

  • Handle filter token when attach watch only account
    Actual: Attach mainnet address but still shows testnet token

    Image

  • Don't show BTC token on Token screen and select token screen( when click icon search)
    Actual:

    Image

    Image

@haiyenvu23
Copy link

haiyenvu23 commented Apr 22, 2025

Version test: https://file.cdmteck.com/s/jzYpR6tbf7A2SeL

@dungnguyen-art
Copy link

  1. Handle filter token with derive account => recheck after merge code issue derivation Extension - Support bitcoin derivation with unified account #4261

@haiyenvu23
Copy link

haiyenvu23 commented Apr 25, 2025

Version test: https://file.cdmteck.com/s/KxCDREJQkREipGn

  • Check avatar for account
    Actual:
    Image
  • Re-check font-weight[/+][-] [ ] Re-check font-weight[/-]
    Actual: font-weight = 600px
    Image
    Expect: font-weight = 500px
  • Wrong BTC balance display
    Address: bc1pgp9qrh482kvusec5r7h6zy0ltl3729zgmenyr6f93kfcu6h2nn3smw9g97
    Actual:
    Image

@dungnguyen-art
Copy link

dungnguyen-art commented Apr 25, 2025

  1. Check avatar for account => Related to issue Extension - Improve UI after Bitcoin integration #4316
  2. Re-check font-weight => No fix needed
  3. Wrong BTC balance display => @phonglnDEV is checking
    Ticket: https://discord.com/channels/447263980252037141/1361622418157862932/1365280747006590976

@haiyenvu23
Copy link

Version test: https://file.cdmteck.com/s/KxCDREJQkREipGn
Validation passed in case:

  • Install/Update version

  • Update UI to show 3 types of BTC addresses in token details screen

    Image

    Image

  • Update UX when get BTC address

    Image

  • Wrong BTC balance display => Related to issue Update logic fetching Bitcoin balance #4162
    Address: bc1pgp9qrh482kvusec5r7h6zy0ltl3729zgmenyr6f93kfcu6h2nn3smw9g97
    Actual:

    Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants