fixed up things

Author: T-rav

source/StoneAge.Data.FileSystem.Tests/DocumentTEsts.cs renamed to source/StoneAge.Data.FileSystem.Tests/DocumentTests.cs

@@ -49,7 +49,7 @@ public void GivenFullFilePath_ExpectFileNameExtracted()
             var input = "a message in a file";
 
             var sut = new DocumentBuilder()
-                .Using_Name_From_Path("c:\\tmp\\test.txt")
+                .Using_Name_From_Path(@"c:\tmp\test.txt")
                 .With_String(input)
                 .Create_Document();
             //---------------Act----------------------

source/StoneAge.Data.FileSystem.Tests/FileSystemTests.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
@@ -217,7 +216,7 @@ public void WhenDirectoryExist_ExpectContents()
                 //---------------Act----------------------
                 var result = sut.List(path);
                 //---------------Assert-----------------------
-                result.Count().Should().BeGreaterOrEqualTo(1);
+                result.Count().Should().BeGreaterThanOrEqualTo(1);
             }
 
             [Test]
@@ -467,9 +466,10 @@ public async Task GivenFileExist_ExpectDocumentWithBytesReturned()
                 //---------------Assert-----------------------
                 var expectedFirst = "GlobalRank,TldRank,Domain,TLD,RefSubNets,RefIPs,IDN_Domain,IDN_TLD,PrevGlobalRank,PrevTldRank,PrevRefSubNets,PrevRefIPs";
                 var expectedLast = "1000000,499336,alexandrevicenzi.com,com,341,364,alexandrevicenzi.com,com,982364,490355,345,368";
-                actual.Count().Should().Be(1000001);
-                actual.FirstOrDefault().Should().BeEquivalentTo(expectedFirst);
-                actual.LastOrDefault().Should().BeEquivalentTo(expectedLast);
+                var enumerable = actual as string[] ?? actual.ToArray();
+                enumerable.Count().Should().Be(1000001);
+                enumerable.FirstOrDefault().Should().BeEquivalentTo(expectedFirst);
+                enumerable.LastOrDefault().Should().BeEquivalentTo(expectedLast);
             }
 
             [Test]
@@ -482,7 +482,7 @@ public void GivenFileDoesExist_ExpectException()
                 //---------------Act----------------------
                 var actual = Assert.ThrowsAsync<FileNotFoundException>(async ()=>await sut.ReadAllLines(path));
                 //---------------Assert-----------------------
-                actual.Message.Should().NotBeEmpty();
+                actual?.Message.Should().NotBeEmpty();
             }
 
             [Test]
@@ -493,7 +493,7 @@ public void GivenNullPath_ExpectException()
                 //---------------Act----------------------
                 var actual = Assert.ThrowsAsync<ArgumentNullException>(async () => await sut.ReadAllLines(null));
                 //---------------Assert-----------------------
-                actual.Message.Should().NotBeEmpty();
+                actual?.Message.Should().NotBeEmpty();
             }
         }
 

source/StoneAge.Data.FileSystem/FileSystem.cs

@@ -9,7 +9,7 @@ namespace StoneAge.FileStore
 {
     public class FileSystem : IFileSystem
     {
-        public static IDocument NullDocument = new Document{Name = "NullDocument"};
+        public static readonly IDocument NullDocument = new Document{Name = "NullDocument"};
 
         public async Task<WriteFileResult> Write(string directory, IDocument file)
         {
@@ -21,6 +21,12 @@ public async Task<WriteFileResult> Write(string directory, IDocument file)
                     result.ErrorMessages.Add("No file name provided");
                     return result;
                 }
+                
+                if (string.IsNullOrWhiteSpace(directory))
+                {
+                    result.ErrorMessages.Add("No directory provided");
+                    return result;
+                }
 
                 result = Ensure_Directory_Is_Created(directory);
 
@@ -161,6 +167,12 @@ public async Task<WriteFileResult> Append(string directory, IDocument file)
                     result.ErrorMessages.Add("No file name provided");
                     return result;
                 }
+                
+                if (string.IsNullOrWhiteSpace(directory))
+                {
+                    result.ErrorMessages.Add("No directory provided");
+                    return result;
+                }
 
                 result = Ensure_Directory_Is_Created(directory);