PHP 8 and Phan checks

Author: kimbtech

.gitignore

@@ -1,2 +1,3 @@
 .DS_Store
-/data/*
+/data/*
+/vendor/*

.phan/config.php

@@ -0,0 +1,44 @@
+<?php
+/*
+	Run check via Docker-Installed Phan:
+
+	# function defined in shell
+	phan() {
+		docker run -v $PWD:/mnt/src --rm -u "1000:1000" phanphp/phan:latest $@; return $?;
+	} 
+
+	# start in document root of project
+	$ phan -o report.txt 
+
+	!! Make sure to have folder vendor in directory !!
+		$ docker build .
+		$ docker create -ti --name dummy <image> bash
+		$ docker cp dummy:/code/vendor/ ./vendor 
+*/
+return [
+	'target_php_version' => '8.0',
+	'directory_list' => [
+		'./bot/',
+		'./vendor/'
+	],
+	'exclude_analysis_directory_list' => [
+		'./vendor/'
+	],
+	'backward_compatibility_checks' => true,
+	'plugins' => [
+		'AlwaysReturnPlugin',
+		'DollarDollarPlugin',
+		'DuplicateArrayKeyPlugin',
+		'DuplicateExpressionPlugin',
+		'PregRegexCheckerPlugin',
+		'PrintfCheckerPlugin',
+		'SleepCheckerPlugin',
+		'UnreachableCodePlugin',
+		'UseReturnValuePlugin',
+		'EmptyStatementListPlugin',
+		'LoopVariableReusePlugin',
+	],
+	'suppress_issue_types' => [
+		'PhanTypeArraySuspiciousNullable'
+	]
+];

Dockerfile

@@ -1,4 +1,4 @@
-FROM kimbtechnologies/php_nginx:latest 
+FROM kimbtechnologies/php_nginx:8-latest 
 
 # copy into webroot
 COPY ./other/hook.php  /php-code/hook.php

VERSION

@@ -1,4 +1,4 @@
 latest
-0.1.1
+0.1.2
 0.1
 0

bot/Commands/Message/GenericmessageCommand.php

@@ -101,7 +101,6 @@ public function execute(): ServerResponse
 					return $this->replyToChat($th->getReplyText(), $opts);
 				default:
 					return $this->replyToChat('Unknown message handler – this should not have happened!');
-					break;
 			}
 
 			$session->setTemp('messageHandler', false);

bot/Commands/StartCommand.php

@@ -21,7 +21,6 @@
 
 use Longman\TelegramBot\Commands\SystemCommand;
 use Longman\TelegramBot\Entities\ServerResponse;
-use Longman\TelegramBot\Exception\TelegramException;
 
 class StartCommand extends SystemCommand
 {

bot/Commands/TaskCommand.php

@@ -21,7 +21,6 @@
 
 use Longman\TelegramBot\Commands\SystemCommand;
 use Longman\TelegramBot\Entities\ServerResponse;
-use Longman\TelegramBot\Exception\TelegramException;
 
 
 class TaskCommand extends SystemCommand

bot/Commands/TttCommand.php

@@ -21,7 +21,6 @@
 
 use Longman\TelegramBot\Commands\SystemCommand;
 use Longman\TelegramBot\Entities\ServerResponse;
-use Longman\TelegramBot\Exception\TelegramException;
 
 class TttCommand extends SystemCommand
 {

bot/classes/JSONReader.php

@@ -60,7 +60,7 @@ public function __construct( $filename, $lockex = false, $otherpath = ''){
 		$this->filehandler = fopen( $this->filepath . '.lock', 'c+' );
 		if( !flock( $this->filehandler, $lockex ? LOCK_EX : LOCK_SH ) ){
 			// error
-			throw new Exception('Unable to lock file!');
+			throw new \Exception('Unable to lock file!');
 		}
 
 		//open file
@@ -78,7 +78,7 @@ public function __construct( $filename, $lockex = false, $otherpath = ''){
 		}
 		else{
 			//error
-			throw new Exception('Unable to find file or folder!');
+			throw new \Exception('Unable to find file or folder!');
 		}
 
 		// no data => empty array
@@ -92,7 +92,7 @@ public function __construct( $filename, $lockex = false, $otherpath = ''){
 		$this->data = json_decode( $this->data, true);
 		//error, if no json etc.
 		if( !is_array( $this->data ) ){
-			throw new Exception('Zombiefile!');	
+			throw new \Exception('Zombiefile!');	
 		}
 
 		//Check if file is writeable?
@@ -194,7 +194,7 @@ public function getValue( array $index, bool $exception = false ){
 			else{
 				//Exception?
 				if( $exception ){
-					throw new Exception( "Unknown Index" );
+					throw new \Exception( "Unknown Index" );
 				}
 				//Fehler
 				return false;

bot/classes/SettingsHelper.php

@@ -32,7 +32,7 @@ public static function syncStep(Session $session, string $text) {
 				break;
 
 			case "Server URI:\t\t":
-				if( !@filter_var($text, FILTER_VALIDATE_URL, FILTER_FLAG_HOST_REQUIRED | FILTER_FLAG_SCHEME_REQUIRED)
+				if( !@filter_var($text, FILTER_VALIDATE_URL)
 					|| substr($text, 0, 4) !== 'http'
 					|| strpos($text, 'localhost') !== false
 					|| strpos($text, ':9000') !== false