Merge pull request #24 from HajMo/patch-1

Custom exception for "Time Bombs"

Author: JustSteveKing

src/Exceptions/ExpiredFeatureException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace JustSteveKing\Laravel\FeatureFlags\Exceptions;
+
+use Exception;
+
+class ExpiredFeatureException extends Exception
+{
+    public static function create(string $feature)
+    {
+        return new static("The Feature {$feature} has expired.");
+    }
+}

src/Models/Feature.php

@@ -5,12 +5,12 @@
 namespace JustSteveKing\Laravel\FeatureFlags\Models;
 
 use Carbon\Carbon;
-use Exception;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Support\Facades\App;
-use JustSteveKing\Laravel\FeatureFlags\Models\Concerns\NormaliseName;
+use JustSteveKing\Laravel\FeatureFlags\Exceptions\ExpiredFeatureException;
 use JustSteveKing\Laravel\FeatureFlags\Models\Builders\FeatureBuilder;
+use JustSteveKing\Laravel\FeatureFlags\Models\Concerns\NormaliseName;
 
 class Feature extends Model
 {
@@ -30,15 +30,15 @@ class Feature extends Model
 
     public static function booted(): void
     {
-        static::retrieved(function(Feature $feature) {
+        static::retrieved(function (Feature $feature) {
             $timeBombsAreEnabled = config('feature-flags.enable_time_bombs');
-            $environmentAllowsTimeBombs = ! App::environment(config('feature-flags.time_bomb_environments'));
+            $environmentAllowsTimeBombs = !App::environment(config('feature-flags.time_bomb_environments'));
 
-            if($timeBombsAreEnabled && $environmentAllowsTimeBombs) {
+            if ($timeBombsAreEnabled && $environmentAllowsTimeBombs) {
                 $featureHasExpired = Carbon::now()->isAfter($feature->expires_at);
 
                 if ($featureHasExpired) {
-                    throw new Exception(sprintf('The Feature has expired - %s', $feature->name));
+                    throw ExpiredFeatureException::create($feature->name);
                 }
                 return true;
             }

tests/Unit/FeatureTimeBombTest.php

@@ -3,6 +3,7 @@
 declare(strict_types=1);
 
 use Carbon\Carbon;
+use JustSteveKing\Laravel\FeatureFlags\Exceptions\ExpiredFeatureException;
 use JustSteveKing\Laravel\FeatureFlags\Models\Feature;
 use Illuminate\Support\Facades\Config;
 
@@ -54,7 +55,7 @@ function tryException() {
     ]);
 
     Feature::all();
-})->throws(Exception::class, 'The Feature has expired - expired feature');
+})->throws(ExpiredFeatureException::class, 'The Feature expired feature has expired.');
 
 it('casts the Expiry date to Carbon', function(): void {
    Feature::create([
@@ -72,7 +73,7 @@ function tryException() {
     ]);
 
     Feature::all();
-})->throws(Exception::class, 'The Feature has expired - expired feature');
+})->throws(ExpiredFeatureException::class, 'The Feature expired feature has expired.');
 
 it('Does not throw an Exception when an expiry date is 1 second in the future', function(): void {
     Feature::create([
@@ -101,4 +102,4 @@ function tryException() {
     ]);
 
     Feature::all();
-})->throws(Exception::class, 'The Feature has expired - expired feature');
+})->throws(ExpiredFeatureException::class, 'The Feature expired feature has expired.');