-
Notifications
You must be signed in to change notification settings - Fork 6
Simplification of the core struct and related methods #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
d1a3f2c
5a20ed2
f1b9f44
1dc1876
961f2fe
1678158
2c3ca7d
906fcce
abe3fb0
7299479
d6dcc90
463b7d7
4fbf2c8
3cd5ae4
e516cc6
24b6e79
59400a2
cef0524
d069ffa
7511d68
6bbc668
9638643
9a6684a
cf9e2c6
df71519
403b9a7
0d649e3
93184bf
1d798d6
af70576
2a1fe2a
9e44507
7f4e086
73f5161
491f086
618f89e
40cca87
1a717d2
e6f234c
45d6a99
6a42b10
b6e58f5
36227c2
e99f69c
49fa6b2
9be1220
1dfacf0
a47daff
2648df3
5a84574
08cd3c4
bf75071
cb37729
1f0f904
0f2560e
436baea
5add2a2
27433ea
bd557ea
b77e8a8
e6fcaa0
14efbf0
1adddb7
b84a381
db2962b
3ba24fb
aad6c08
36607e5
a1d4066
cde70ae
e7835da
ba74aca
f1539cb
3c5cc82
6d0c869
bb79e6d
4efb266
ab91387
0150597
df3e2f2
f8b72de
ff833ee
10f94dd
addbbec
80f23d2
1abc592
ed30593
a41e1ce
893ff67
96968ae
a7a1211
b4986c7
338167d
6c23034
d95841c
fdd4759
4344cb4
e86c613
c1ef286
612fb94
16844b7
c61765d
bd0f42c
56d7279
a8c8139
903033e
a07455d
d07cdad
f58db86
196004b
c159f1a
e7dcc80
338c360
6d9234c
a8ac346
ea14380
83a6789
785520f
bcab248
f2263f3
86a8ee5
a303056
93fefc9
9af1968
1e248b1
cc3ceb6
bf4f6fa
263b886
a4b5945
83a3500
ae3c599
e2112c4
99e71f9
e3b84b7
c8b68ea
7e1adc0
0067cf5
661fa7e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This now adds random perturbations even for counterfactuals using latent space search. That seems redundant but it also doesn't seem to hurt and is probably more consistent. So happy if you're all happy with this. Also: Not in this PR, but for consistency should we treat initialization in the same way as convergence? What do you people think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the same way as that it is its own struct? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,19 +8,7 @@ Initializes the starting point for the factual(s): | |
| """ | ||
| function initialize_state(ce::CounterfactualExplanation) | ||
| @assert ce.initialization ∈ [:identity, :add_perturbation] | ||
|
|
||
| s′ = ce.s′ | ||
| data = ce.data | ||
|
|
||
| # No perturbation: | ||
| if ce.initialization == :identity | ||
| return s′ | ||
| end | ||
|
|
||
| # If latent space, initial point is random anyway: | ||
| if ce.params[:latent_space] | ||
| return s′ | ||
| end | ||
|
Comment on lines
-13
to
-23
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you explain to me please, why is this deleted? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The function returns unmodified There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wait, now I noticed that |
||
|
|
||
| # Add random perturbation following Slack (2021): https://arxiv.org/abs/2106.02666 | ||
| if ce.initialization == :add_perturbation | ||
|
|
||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.