fix up solvers, prep for operator and compile changes

Author: rayegun

src/solvers/klu.jl

@@ -378,5 +378,4 @@ function LinearAlgebra.ldiv!(klu::LinearAlgebra.AdjOrTrans{Tv, K}, B::AbstractGB
     map!(complex, B, realX, imagX)
 end
 # No refactors for now. TODO: Enable refactors!!!
-
-end
+end

src/solvers/umfpack.jl

@@ -29,7 +29,6 @@ import SuiteSparse.UMFPACK: umfpack_numeric!, _AqldivB_kernel!,
 umfpack_extract, umfpack_symbolic!, _Aq_ldiv_B!, solve!, umf_lunz
 using SuiteSparse.LibSuiteSparse
 import SuiteSparse.LibSuiteSparse:
-    SuiteSparse_long,
     umfpack_dl_defaults,
     umfpack_dl_report_control,
     umfpack_dl_report_info,

test/solvers/cholmod.jl

@@ -13,7 +13,6 @@ using LinearAlgebra:
     PosDefException, ZeroPivotException
 using SparseArrays
 using SparseArrays: getcolptr
-using SuiteSparse.LibSuiteSparse: SuiteSparse_long
 using SuiteSparseGraphBLAS
 using SuiteSparse.LibSuiteSparse
 if Base.USE_GPL_LIBS

test/solvers/klu.jl

@@ -58,7 +58,7 @@ using SuiteSparseGraphBLAS: GBDiagonal
 
             @testset "Permutation vectors" begin
                 #Just to test this works, we'll use the existing permutation vectors.
-                @test klu_analyze!(klua, klua.p, klua.q).common.status == 0
+                @test klu_analyze!(klua, klua.p, klua.q).common.status >= 0
                 klu_factor!(klua)
                 x = klua \ b
                 @test A*x ≈ b
@@ -122,4 +122,4 @@ end
     F = klua.F
     @test !SuiteSparseGraphBLAS.isshallow(F)
     unsafeunpack!(A, SuiteSparseGraphBLAS.Sparse())
-end
+end