Use OncePerTask instead of a handmade thread local cache
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrobinson251
approved these changes
Oct 7, 2025
| end | ||
|
|
||
| function _divpow10!(x::BigInt, code, pow, ::RoundingMode{:Throw}) | ||
| @inbounds y = Parsers.access_threaded(() -> (@static VERSION > v"1.5" ? BigInt(; nbits=256) : BigInt()), _BIGINT_10s) # we must not yield here! |
There was a problem hiding this comment.
we've dropped the @inbounds here -- tbh i can't see where there would be bounds-checking that this disables, but perhaps there is somewhere in a nested call? (or maybe access_threaded meant to have a @boundscheck but didn't?)
probably it's fine to drop (but i wish this repo had benchmarks)
There was a problem hiding this comment.
It seems to me that access_threaded already elides bounds checking, so this should be fine
I've very scientifically added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copy-pasted the identical fix from JuliaData/Parsers.jl#195
Fixes: #120
Bumps version to
0.6.4