Skip to content

Commit f2a5c87

Browse files
kshyattmaleadt
andauthored
Improve support for Julia 1.12-rc (#2888)
[only julia] Co-authored-by: Tim Besard <[email protected]>
1 parent 8a961f0 commit f2a5c87

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

.buildkite/pipeline.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ steps:
3131
julia:
3232
- "1.10"
3333
- "1.11"
34+
- "1.12-nightly"
3435
- "nightly"
3536
adjustments:
37+
- with:
38+
julia: "1.12-nightly"
39+
soft_fail: true
3640
- with:
3741
julia: "nightly"
3842
soft_fail: true

lib/cublas/linalg.jl

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# interfacing with LinearAlgebra standard library
22

33
using LinearAlgebra: MulAddMul, AdjOrTrans, wrap, UpperOrLowerTriangular, rmul!, lmul!
4-
4+
@static if VERSION v"1.12.0-rc"
5+
# we need to use the generic wrapper to avoid dispatch to the 2x2or3x3 method
6+
using LinearAlgebra: generic_matmatmul_wrapper!, BlasFlag
7+
end
58
#
69
# BLAS 1
710
#
@@ -225,6 +228,13 @@ end
225228
#
226229

227230
# GEMM
231+
232+
@static if VERSION v"1.12.0-rc"
233+
function LinearAlgebra.generic_matmatmul_wrapper!(C::StridedCuMatrix{T}, tA::AbstractChar, tB::AbstractChar, A::StridedCuVecOrMat{T}, B::StridedCuVecOrMat{T}, alpha::Number, beta::Number, val::LinearAlgebra.BlasFlag.SyrkHerkGemm) where {T<:CublasFloat}
234+
LinearAlgebra.generic_matmatmul!(C, tA, tB, A, B, alpha, beta)
235+
end
236+
end
237+
228238
LinearAlgebra.generic_matmatmul!(C::StridedCuVecOrMat, tA, tB, A::StridedCuVecOrMat, B::StridedCuVecOrMat, _add::MulAddMul) =
229239
LinearAlgebra.generic_matmatmul!(C, tA, tB, A, B, _add.alpha, _add.beta)
230240
function LinearAlgebra.generic_matmatmul!(C::StridedCuVecOrMat, tA, tB, A::StridedCuVecOrMat, B::StridedCuVecOrMat, alpha::Number, beta::Number)

0 commit comments

Comments
 (0)