Extend conversion of QRPackedQ object to CuArray (#1662)

Author: GVigne

lib/cusolver/linalg.jl

@@ -114,6 +114,7 @@ CuArray{T}(Q::AbstractQ) where {T} = CuMatrix{T}(Q)
 CuMatrix(Q::AbstractQ{T}) where {T} = CuMatrix{T}(Q)
 CuMatrix{T}(Q::QRPackedQ{S}) where {T,S} =
     CuMatrix{T}(lmul!(Q, CuMatrix{S}(I, size(Q, 1), min(size(Q.factors)...))))
+CuMatrix{T, B}(Q::QRPackedQ{S}) where {T, B, S} = CuMatrix{T}(Q)
 CuMatrix{T}(Q::QRCompactWYQ) where {T} = error("QRCompactWY format is not supported")
 # avoid the CPU array in the above mul!
 Matrix{T}(Q::QRPackedQ{S,<:CuArray,<:CuArray}) where {T,S} = Array(CuMatrix{T}(Q))
@@ -161,7 +162,8 @@ CuQRPackedQ(factors::AbstractMatrix{T}, τ::CuVector{T}) where {T} =
 # AbstractQ's `size` is the size of the full matrix,
 # while `Matrix(Q)` only gives the compact Q.
 # See JuliaLang/julia#26591 and JuliaGPU/CUDA.jl#969.
-CuMatrix{T}(Q::AbstractQ{S}) where {T,S} = convert(CuArray, Matrix{T}(Q))
+CuMatrix{T}(Q::AbstractQ{S}) where {T,S} = convert(CuArray{T}, Matrix(Q))
+CuMatrix{T, B}(Q::AbstractQ{S}) where {T, B, S} = CuMatrix{T}(Q)
 CuMatrix(Q::AbstractQ{T}) where {T} = CuMatrix{T}(Q)
 CuArray{T}(Q::AbstractQ) where {T} = CuMatrix{T}(Q)
 CuArray(Q::AbstractQ) = CuMatrix(Q)

test/cusolver/dense.jl

@@ -421,6 +421,7 @@ k = 1
         @test Array(h_q) ≈ Array(q)
         @test collect(CuArray(h_q)) ≈ Array(q)
         @test Array(h_r) ≈ Array(r)
+        @test CuArray(h_q) ≈ convert(typeof(d_A), h_q)
         A              = rand(elty, n, m)
         d_A            = CuArray(A)
         h_q, h_r       = qr(d_A) # FixMe! Use iteration protocol when implemented