From 9d90ab6856c483a580454de67824f22a7554fdec Mon Sep 17 00:00:00 2001 From: Simeon Schaub Date: Mon, 8 Feb 2021 15:59:49 +0100 Subject: [PATCH 1/2] fix AD demos on Julia nightly --- test/demos/forwarddiffzero.jl | 2 +- test/demos/reversediffzero.jl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/demos/forwarddiffzero.jl b/test/demos/forwarddiffzero.jl index 4a77c237e..13a1b1971 100644 --- a/test/demos/forwarddiffzero.jl +++ b/test/demos/forwarddiffzero.jl @@ -32,7 +32,7 @@ function define_dual_overload(sig) opT, argTs = Iterators.peel(sig.parameters) opT isa Type{<:Type} && return # not handling constructors fieldcount(opT) == 0 || return # not handling functors - all(Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops. + all(argT isa Type && Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops. N = length(sig.parameters) - 1 # skip the op fdef = quote diff --git a/test/demos/reversediffzero.jl b/test/demos/reversediffzero.jl index 2f1a5e3e1..540b8ea20 100644 --- a/test/demos/reversediffzero.jl +++ b/test/demos/reversediffzero.jl @@ -61,7 +61,7 @@ function define_tracked_overload(sig) opT, argTs = Iterators.peel(sig.parameters) opT isa Type{<:Type} && return # not handling constructors fieldcount(opT) == 0 || return # not handling functors - all(Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops. + all(argT isa Type && Float64 <: argT for argT in argTs) || return # only handling purely Float64 ops. N = length(sig.parameters) - 1 # skip the op fdef = quote From df971684edbba60deaafbab4d36fc1c83749beaa Mon Sep 17 00:00:00 2001 From: Simeon Schaub Date: Mon, 8 Feb 2021 21:42:38 +0100 Subject: [PATCH 2/2] bump patch version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 2fd0d7c59..d4363ab3a 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "ChainRulesCore" uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" -version = "0.9.27" +version = "0.9.28" [deps] Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"