Remove old warning about map #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Sep 29, 2025
There was a problem hiding this comment.
The fix (JuliaLang/julia@bb31772) is only available in Julia >= 1.10.0-alpha1 but ChainRules currently supports Julia >= 1.6.0.
Thus this PR either has to update the minimum Julia version to 1.10.0 (which IMO should be done in a separate PR though since it might entail other changes such as updates to CI and removal of VERSION specific branches) or the check has to be removed only in more recent Julia versions.
moble
force-pushed
the
map_mismatched_lengths
branch
from
b9e8276 to
41c3252
Compare
|
Good point. I've kept the check now, but wrapped it in a static version check. |
devmotion
reviewed
Sep 30, 2025
Co-authored-by: David Müller-Widmann <[email protected]>
|
Alright, checks made more precise. The relevant test is still passing. |
devmotion
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #798
There already was a test that hits this, so I've just removed the error message.