Merge pull request #544 from JuliaArrays/teh/dm2

Increase exception-type specificity for a few errors and tests

Author: timholy

src/convert.jl

@@ -1,4 +1,5 @@
-(::Type{SA})(x::Tuple{Tuple{Tuple{<:Tuple}}}) where {SA <: StaticArray} = error("No precise constructor for $SA found. Length of input was $(length(x[1][1][1])).")
+(::Type{SA})(x::Tuple{Tuple{Tuple{<:Tuple}}}) where {SA <: StaticArray} =
+    throw(DimensionMismatch("No precise constructor for $SA found. Length of input was $(length(x[1][1][1]))."))
 
 @inline (::Type{SA})(x...) where {SA <: StaticArray} = SA(x)
 @inline (::Type{SA})(a::StaticArray) where {SA<:StaticArray} = SA(Tuple(a))

test/FieldVector.jl

@@ -40,7 +40,7 @@
         @test [[Point3D(1.0,2.0,3.0)]; [Point3D(4.0,5.0,6.0)]]::Vector{Point3D} == [Point3D(1.0,2.0,3.0), Point3D(4.0,5.0,6.0)]
 
         # Issue 342
-        @test_throws ErrorException Point3D(1,2,3,4)
+        @test_throws DimensionMismatch("No precise constructor for Point3D found. Length of input was 4.") Point3D(1,2,3,4)
     end
 
     @testset "Mutable Point2D" begin

test/SDiagonal.jl

@@ -54,9 +54,9 @@ using StaticArrays, Test, LinearAlgebra
             end
         end
 
-        @test_throws Exception m[5,5]
+        @test_throws BoundsError m[5,5]
 
-        @test_throws Exception m[1,5]
+        @test_throws BoundsError m[1,5]
 
 
         @test size(m) === (4, 4)

test/core.jl

@@ -19,7 +19,7 @@
     @testset "Type parameter errors" begin
         # (not sure what type of exception these should be?)
         @test_throws Exception SVector{1.0,Int}((1,))
-        @test_throws Exception SVector{2,Int}((1,))
+        @test_throws DimensionMismatch("No precise constructor for SArray{Tuple{2},$Int,1,2} found. Length of input was 1.") SVector{2,Int}((1,))
         @test_throws Exception SVector{1,3}((1,))
 
         @test_throws Exception SMatrix{1.0,1,Int,1}((1,))
@@ -134,13 +134,13 @@
         @test @inferred(convert(Array{Int}, ma)) == a
         @test @inferred(convert(Array{Int,2}, ma)) == a
 
-        # broken, see https://github.com/JuliaArrays/StaticArrays.jl/pull/448#discussion_r197977273
         try
             convert(SVector, [1,2,3])
         catch err
             @test isa(err, ErrorException)
             @test startswith(err.msg, "The size of type")
         end
+        @test_throws DimensionMismatch("expected input array of length 2, got length 3") convert(SVector{2}, [1,2,3])
     end
     @test_throws Exception Length{2.5}()
     @test Length(2) == Length{2}()