Skip to content

Commit 359273e

Browse files
authored
Tweak comment to point to julia compiler inlining issue
1 parent ddd2fb6 commit 359273e

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/MArray.jl

+2-4
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,8 @@ end
9797
# This is inherently slow because we've got to rebuild a new Tuple to
9898
# reassign to data.v.
9999
#
100-
# However it seems not possible to make fast without having some kind
101-
# of mutable pseudo-container which is inlined as a part of the parent
102-
# struct such that you can't access it separately. (A mutable
103-
# FieldArray achieves this, but can't be parameterized on the size.)
100+
# However it seems not possible to make fast, at least in julia 1.4
101+
# TODO: Revisit if https://github.com/JuliaLang/julia/pull/34126 is merged
104102
@inbounds v.data = setindex(v.data, val, i)
105103
end
106104

0 commit comments

Comments
 (0)