Skip to content

Commit 15a2672

Browse files
authored
stop pirating size(::Type{Union{}}) (#1306)
JET complained about this method when analyzing my package and it's a fairly easy fix
1 parent e23a2f5 commit 15a2672

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/SDiagonal.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ SDiagonal(x...) = Diagonal(SVector(x...))
1414
SDiagonal(a::SVector) = Diagonal(a)
1515
SDiagonal(a::StaticMatrix{N,N,T}) where {N,T} = Diagonal(diag(a))
1616

17-
size(::Type{<:SDiagonal{N}}) where {N} = (N,N)
18-
size(::Type{<:SDiagonal{N}}, d::Int) where {N} = d > 2 ? 1 : N
17+
size(::Type{SDiagonal{N}}) where {N} = (N,N)
18+
size(::Type{SDiagonal{N,T}}) where {N,T} = (N,N)
19+
size(::Type{SDiagonal{N}}, d::Int) where {N} = d > 2 ? 1 : N
20+
size(::Type{SDiagonal{N,T}}, d::Int) where {N,T} = d > 2 ? 1 : N
1921

2022
# define specific methods to avoid allocating mutable arrays
2123
\(D::SDiagonal, b::AbstractVector) = D.diag .\ b

0 commit comments

Comments
 (0)