Skip to content

Commit 72374b9

Browse files
committed
Add notes to producer and remove build step for stats
Not sure about adding the stats to the project, and I am just using it as a large data loader for testing. But its convenient keeping it in the project.
1 parent e2da07b commit 72374b9

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/kafka-net.sln

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ Global
4646
{53E0B3CE-6C41-4C8A-8B66-9BD03667B1E0}.Release|Any CPU.ActiveCfg = Release|Any CPU
4747
{53E0B3CE-6C41-4C8A-8B66-9BD03667B1E0}.Release|Any CPU.Build.0 = Release|Any CPU
4848
{02E1B2E3-E1B2-4E68-9BD9-95F266302C75}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
49-
{02E1B2E3-E1B2-4E68-9BD9-95F266302C75}.Debug|Any CPU.Build.0 = Debug|Any CPU
5049
{02E1B2E3-E1B2-4E68-9BD9-95F266302C75}.Release|Any CPU.ActiveCfg = Release|Any CPU
5150
{02E1B2E3-E1B2-4E68-9BD9-95F266302C75}.Release|Any CPU.Build.0 = Release|Any CPU
5251
EndGlobalSection

src/kafka-net/Producer.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ private async Task ProduceAndSendBatchAsync(List<TopicMessage> batchs, Cancellat
281281

282282
foreach (var task in sendTasks)
283283
{
284+
//TODO when we dont ask for an ACK, result is an empty list. Which FirstOrDefault returns null. Dont like this...
284285
task.MessagesSent.ForEach(x => x.Tcs.TrySetResult(task.Task.Result.FirstOrDefault()));
285286
}
286287
}

0 commit comments

Comments
 (0)