Skip to content

Commit 09efb9b

Browse files
committed
Cleanup code and docs.
1 parent 9f9865a commit 09efb9b

File tree

11 files changed

+31
-35
lines changed

11 files changed

+31
-35
lines changed

README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,9 @@ In this case the latest `library descriptor` will be pulled from the [Kotlin Jup
103103
#### Library Descriptor Parameters
104104

105105
```
106-
%use lets-plot(api=4.9.0, lib=4.5.1, js=4.5.1, isolatedFrame=false)
106+
%use lets-plot(v=4.9.0, isolatedFrame=false)
107107
```
108-
- `api` - version of the Lets-Plot Kotlin API.
109-
- `lib` - version of the Lets-Plot Multiplatform (JARs).
110-
- `js` - version of the Lets-PLot Multiplatform JavaScript bundle.
108+
- `v` - version of the Lets-Plot Kotlin API.
111109
- `isolatedFrame` - If `false`: load JS just once per notebook (default in Jupyter).
112110
If `true`: include Lets-Plot JS in each output (default in [Datalore](https://datalore.jetbrains.com/) notebooks).
113111

devdocs/JUPYTER_KOTLIN_KERNEL.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,12 @@ Otherwise, Kotlin Kernel uses 'bundled' descriptors installed to:
5454
5555
## Conducting experiments with Kotlin Kernel locally.
5656

57+
Clear Maven cache:
58+
`$ rm -rf ~/.m2/repository/org/jetbrains/lets-plot`
59+
5760
#### 1) Publish artifacts to the local dev-repo:
5861

59-
`$ ./gradlew publishLetsPlotKotlinKernelPublicationToMavenLocalRepository`
62+
`$ ./gradlew publishJvmPublicationToMavenLocalRepository`
6063
`$ ./gradlew publishLetsPlotKotlinGeoToolsPublicationToMavenLocalRepository`
6164
`$ ./gradlew publishletsPlotKotlinJupyterPublicationToMavenLocalRepository`
6265
`$ ./gradlew publishletsPlotKotlinGeotoolsJupyterPublicationToMavenLocalRepository`
@@ -87,9 +90,7 @@ The kernel can download a newer descriptor at any moment.
8790
- configure the artifacts version (published Lets-Plot JS):
8891
```
8992
"properties": {
90-
"api": "3.1.2-alpha2",
91-
"lib": "2.3.0-rc2",
92-
"js": "2.3.0rc2",
93+
"v": "3.1.2-alpha2",
9394
"isolatedFrame": ""
9495
},
9596
```

future_changes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## [4.9.1] - 202y-mm-dd
22

3+
This release is 100% compatible with Lets-Plot [v 4.5.1](https://github.com/JetBrains/lets-plot/releases/tag/v4.5.1),
4+
GeoTools [v 32.1](https://github.com/geotools/geotools/releases/tag/32.0)
5+
36
### Added
47

58

gradle.properties

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,4 @@ jupyterApi.version=0.12.0-313
3232

3333
# Also update JS version in <home>/demo/js-frontend-app/src/main/resources/index.html
3434
letsPlot.version=4.5.1
35-
36-
# The latest GeoTools 30-RC do not compile due to
37-
# "renaming of all "org.opengis" packages into "org.geotools.api" ones"
38-
# See release notes: http://geotoolsnews.blogspot.com/2023/09/geotools-30-rc-released.html
39-
#
40-
# The most recent compatible version is 29.2
41-
# See Sourceforge: https://sourceforge.net/projects/geotools/files/
42-
#geotools.version=[23,)
43-
geotools.version=[30,)
35+
geotools.version=[32.1]

plot-api/build.gradle.kts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,10 @@ kotlin {
3939

4040
named("jvmMain") {
4141
dependencies {
42-
implementation("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
42+
// implementation("io.github.microutils:kotlin-logging:$kotlinLoggingVersion")
4343
api("org.jetbrains.lets-plot:lets-plot-common:$letsPlotVersion")
44+
api("io.github.microutils:kotlin-logging-jvm:$kotlinLoggingVersion")
45+
4446
// Use "-jvm" variant to work around the issue where LPK JS (IR) artefact becomes dependent on
4547
// the "kotlinx-datetime".
4648
// See also:

toolkit/geotools-jupyter/build.gradle.kts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,17 @@ repositories {
1515
val geoToolsVersion = extra["geotools.version"] as String
1616

1717
dependencies {
18-
implementation(projects.plotApi)
18+
compileOnly(projects.plotApi)
1919
// basic LPK jupyter integration
20-
implementation(projects.jupyter)
20+
compileOnly(projects.jupyter)
2121

2222
// geotools implementations
2323
implementation(projects.geotools)
2424
implementation("org.geotools:gt-main:$geoToolsVersion")
2525
implementation("org.geotools:gt-geojson:$geoToolsVersion")
2626

27+
testImplementation(projects.plotApi)
28+
testImplementation(projects.jupyter)
2729
testImplementation(kotlin("test"))
2830
}
2931

toolkit/geotools-jupyter/src/main/kotlin/org/jetbrains/letsPlot/toolkit/geotools/jupyter/Integration.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@ package org.jetbrains.letsPlot.toolkit.geotools.jupyter
33
import org.jetbrains.kotlinx.jupyter.api.Notebook
44
import org.jetbrains.kotlinx.jupyter.api.libraries.JupyterIntegration
55
import org.jetbrains.kotlinx.jupyter.api.libraries.repositories
6-
import org.jetbrains.letsPlot.export.VersionChecker
76

87
@Suppress("unused")
9-
class Integration(private val notebook: Notebook, private val options: MutableMap<String, String?>) :
8+
class Integration(private val notebook: Notebook, options: MutableMap<String, String?>) :
109
JupyterIntegration() {
11-
private val api = options["api"] ?: VersionChecker.letsPlotKotlinAPIVersion
1210
override fun Builder.onLoaded() {
1311
repositories {
1412
maven("https://repo.osgeo.org/repository/release")

toolkit/geotools/build.gradle.kts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,12 @@ plugins {
1212
val geoToolsVersion = extra["geotools.version"] as String
1313

1414
dependencies {
15-
implementation(projects.plotApi)
15+
compileOnly(projects.plotApi)
1616

1717
compileOnly("org.geotools:gt-main:$geoToolsVersion")
1818
compileOnly("org.geotools:gt-geojson:$geoToolsVersion")
1919

20+
testImplementation(projects.plotApi)
2021
testImplementation(kotlin("test"))
2122
testImplementation("org.geotools:gt-main:$geoToolsVersion")
2223
testImplementation("org.geotools:gt-geojson:$geoToolsVersion")

toolkit/json/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ plugins {
77
val serializationVersion = extra["serialization.version"] as String
88

99
dependencies {
10-
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:$serializationVersion")
10+
api("org.jetbrains.kotlinx:kotlinx-serialization-json:$serializationVersion")
1111

1212
testImplementation(kotlin("test"))
1313
}

toolkit/jupyter/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ dependencies {
1414
// All LP/LPK implementations to be loaded in notebook
1515
implementation(projects.plotApi)
1616

17-
implementation("org.jetbrains.lets-plot:lets-plot-common:$letsPlotVersion")
17+
// implementation("org.jetbrains.lets-plot:lets-plot-common:$letsPlotVersion")
1818
implementation("org.jetbrains.lets-plot:platf-awt-jvm:$letsPlotVersion")
1919
implementation("org.jetbrains.lets-plot:lets-plot-image-export:$letsPlotVersion")
20-
implementation("io.github.microutils:kotlin-logging-jvm:$kotlinLoggingVersion")
20+
// implementation("io.github.microutils:kotlin-logging-jvm:$kotlinLoggingVersion")
2121

2222
implementation(projects.json)
23-
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3")
23+
// implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3")
2424

2525
testImplementation(kotlin("test"))
2626
}

0 commit comments

Comments
 (0)