Skip to content

Metadata verification settings #448

Open
@jkakavas

Description

@jkakavas

For all of the InMemoryMetadata based classes, the signature checking is made in a rather implicit and not obvious way with the use of https://github.com/rohe/pysaml2/blob/1da840e4dc4b7ea4685dca4f214b87b5d5d17d95/src/saml2/mdstore.py#L634-L651

That basically says that if self.cert is False for any reason, then we don't do verification and assume the deployer didn't want to do any verification. What's more we return True ( implying we checked and verified the signature ).

We should probably make signature checking more of an explicit setting and not deduce that from the absence/presence of an (admittedly related) configuration option. Or at least make sure that it is clearer in the configuration

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions