Skip to content

Commit dfb253f

Browse files
authored
Merge branch 'master' into fix/user-status
2 parents 0dee1d0 + 6bc7b0b commit dfb253f

File tree

8 files changed

+19
-24
lines changed

8 files changed

+19
-24
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -396,8 +396,8 @@ leave: ## Forces to stop all services, networks, etc by the node leaving the swa
396396

397397
.PHONY: .init-swarm
398398
.init-swarm:
399-
# Ensures swarm is initialized (careful we use a default pool of 10.20.0.0/16. Ensure you do not use private IPs in that range!)
400-
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip) --default-addr-pool 10.20.0.0/16)
399+
# Ensures swarm is initialized (careful we use a default pool of 172.20.0.0/14. Ensure you do not use private IPs in that range!)
400+
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip) --default-addr-pool 172.20.0.0/14)
401401

402402

403403
## DOCKER TAGS -------------------------------

services/autoscaling/tests/manual/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ down: .env ## stops local test app dependencies (running bare metal against AWS)
3939
SWARM_HOSTS = $(shell docker node ls --format="{{.Hostname}}" 2>$(if $(IS_WIN),NUL,/dev/null))
4040
.PHONY: .init-swarm
4141
.init-swarm:
42-
# Ensures swarm is initialized
43-
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip))
42+
# Ensures swarm is initialized (careful we use a default pool of 172.20.0.0/14. Ensure you do not use private IPs in that range!)
43+
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip) --default-addr-pool 172.20.0.0/14)

services/autoscaling/tests/manual/docker-compose-computational.yml

-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ services:
55
- DASK_MONITORING_URL=tcp://dask-scheduler:8786
66
- DASK_SCHEDULER_AUTH='{}'
77
dask-sidecar:
8-
dns: 8.8.8.8 # needed to access internet
98
image: itisfoundation/dask-sidecar:master-github-latest
109
init: true
1110
hostname: "{{.Node.Hostname}}-{{.Service.Name}}"
@@ -31,7 +30,6 @@ services:
3130
- "node.role==worker"
3231

3332
dask-scheduler:
34-
dns: 8.8.8.8 # needed to access internet
3533
image: itisfoundation/dask-sidecar:master-github-latest
3634
init: true
3735
hostname: "{{.Node.Hostname}}-{{.Service.Name}}-{{.Task.Slot}}"

services/autoscaling/tests/manual/docker-compose.yml

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ services:
3535

3636
autoscaling:
3737
image: local/autoscaling:development
38-
dns: 8.8.8.8 # needed to access internet
3938
init: true
4039
hostname: "{{.Node.Hostname}}-{{.Service.Name}}-{{.Task.Slot}}"
4140
ports:

services/clusters-keeper/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ down: .env ## stops local test app dependencies (running bare metal against AWS)
1717

1818
PHONY: .init-swarm
1919
.init-swarm:
20-
# Ensures swarm is initialized
21-
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip))
20+
# Ensures swarm is initialized (careful we use a default pool of 172.20.0.0/14. Ensure you do not use private IPs in that range!)
21+
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip) --default-addr-pool 172.20.0.0/14)
2222

2323

2424
.PHONY: test-dask-scheduler-deploy

services/clusters-keeper/src/simcore_service_clusters_keeper/data/docker-compose.yml

+10-13
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ version: "3.8"
22
services:
33
dask-scheduler:
44
image: ${DOCKER_REGISTRY:-itisfoundation}/dask-sidecar:${DOCKER_IMAGE_TAG}
5-
dns: 8.8.8.8 # needed to access internet from AWS
65
init: true
76
hostname: "{{.Node.Hostname}}-{{.Task.Slot}}"
87
environment:
@@ -23,17 +22,16 @@ services:
2322
secrets:
2423
- source: dask_tls_ca
2524
target: ${DASK_TLS_CA_FILE}
26-
mode: 0444
25+
mode: 444
2726
- source: dask_tls_key
2827
target: ${DASK_TLS_KEY}
29-
mode: 0444
28+
mode: 444
3029
- source: dask_tls_cert
3130
target: ${DASK_TLS_CERT}
32-
mode: 0444
31+
mode: 444
3332

3433
dask-sidecar:
3534
image: ${DOCKER_REGISTRY:-itisfoundation}/dask-sidecar:${DOCKER_IMAGE_TAG}
36-
dns: 8.8.8.8 # needed to access internet from AWS
3735
init: true
3836
hostname: "{{.Node.Hostname}}-{{.Task.Slot}}"
3937
volumes:
@@ -62,17 +60,16 @@ services:
6260
secrets:
6361
- source: dask_tls_ca
6462
target: ${DASK_TLS_CA_FILE}
65-
mode: 0444
63+
mode: 444
6664
- source: dask_tls_key
6765
target: ${DASK_TLS_KEY}
68-
mode: 0444
66+
mode: 444
6967
- source: dask_tls_cert
7068
target: ${DASK_TLS_CERT}
71-
mode: 0444
69+
mode: 444
7270

7371
autoscaling:
7472
image: ${DOCKER_REGISTRY:-itisfoundation}/autoscaling:${DOCKER_IMAGE_TAG}
75-
dns: 8.8.8.8 # needed to access internet from AWS
7673
init: true
7774
hostname: "{{.Node.Hostname}}-{{.Task.Slot}}"
7875
environment:
@@ -106,18 +103,17 @@ services:
106103
secrets:
107104
- source: dask_tls_ca
108105
target: ${DASK_TLS_CA_FILE}
109-
mode: 0444
106+
mode: 444
110107
- source: dask_tls_key
111108
target: ${DASK_TLS_KEY}
112-
mode: 0444
109+
mode: 444
113110
- source: dask_tls_cert
114111
target: ${DASK_TLS_CERT}
115-
mode: 0444
112+
mode: 444
116113

117114
redis:
118115
# NOTE: currently autoscaling requires redis to run
119116
image: "redis:6.2.6@sha256:4bed291aa5efb9f0d77b76ff7d4ab71eee410962965d052552db1fb80576431d"
120-
dns: 8.8.8.8 # needed to access internet from AWS
121117
init: true
122118
hostname: "{{.Node.Hostname}}-{{.Task.Slot}}"
123119
healthcheck:
@@ -137,6 +133,7 @@ volumes:
137133
name: computational_shared_data
138134
redis-data:
139135

136+
140137
secrets:
141138
dask_tls_ca:
142139
file: ${DASK_TLS_CA_FILE}

services/clusters-keeper/src/simcore_service_clusters_keeper/utils/clusters.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ def create_startup_script(
117117
# NOTE: https://stackoverflow.com/questions/41203492/solving-redis-warnings-on-overcommit-memory-and-transparent-huge-pages-for-ubunt
118118
"sysctl vm.overcommit_memory=1",
119119
f"echo '{_docker_compose_yml_base64_encoded()}' | base64 -d > {_HOST_DOCKER_COMPOSE_PATH}",
120-
"docker swarm init",
120+
# NOTE: --default-addr-pool is necessary in order to prevent conflicts with AWS node IPs
121+
"docker swarm init --default-addr-pool 172.20.0.0/14",
121122
f"{' '.join(environment_variables)} docker stack deploy --with-registry-auth --compose-file={_HOST_DOCKER_COMPOSE_PATH} dask_stack",
122123
]
123124
)

services/osparc-gateway-server/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ SWARM_HOSTS = $(shell docker node ls --format="{{.Hostname}}" 2>$(if $(IS_WIN),N
5555
PHONY: .init-swarm
5656
.init-swarm:
5757
# Ensures swarm is initialized
58-
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip))
58+
$(if $(SWARM_HOSTS),,docker swarm init --advertise-addr=$(get_my_ip) --default-addr-pool 172.20.0.0/14)
5959

6060
.PHONY: config
6161
export OSPARC_GATEWAY_CONFIG_FILE_HOST = .osparc-dask-gateway-config.py

0 commit comments

Comments
 (0)