@sanderegg review: base api exception private

Author: pcrespov

packages/models-library/src/models_library/api_schemas_payments/errors.py

@@ -1,28 +1,28 @@
 from pydantic.errors import PydanticErrorMixin
 
 
-class BaseServiceError(PydanticErrorMixin, ValueError):
+class _BaseServiceApiError(PydanticErrorMixin, ValueError):
     @classmethod
     def get_full_class_name(cls) -> str:
         # Can be used as unique code identifier
         return f"{cls.__module__}.{cls.__name__}"
 
 
 #
-# service wide  errors
+# service-wide errors
 #
 
 
-class PaymentServiceUnavailableError(BaseServiceError):
+class PaymentServiceUnavailableError(_BaseServiceApiError):
     msg_template = "Payments are currently unavailable: {human_reason}"
 
 
 #
-# payments
+# payment transactions errors
 #
 
 
-class PaymentsError(BaseServiceError):
+class PaymentsError(_BaseServiceApiError):
     msg_template = "Error in payment transaction '{payment_id}'"
 
 
@@ -39,11 +39,11 @@ class PaymentAlreadyAckedError(PaymentsError):
 
 
 #
-# payment-methods
+# payment-methods errors
 #
 
 
-class PaymentsMethodsError(BaseServiceError):
+class PaymentsMethodsError(_BaseServiceApiError):
     ...
 
 

services/payments/src/simcore_service_payments/core/errors.py

@@ -1,11 +1,19 @@
-from models_library.api_schemas_payments.errors import BaseServiceError
+from pydantic.errors import PydanticErrorMixin
+
+
+class _BaseServiceInternalError(PydanticErrorMixin, ValueError):
+    @classmethod
+    def get_full_class_name(cls) -> str:
+        # Can be used as unique code identifier
+        return f"{cls.__module__}.{cls.__name__}"
+
 
 #
 # gateway  errors
 #
 
 
-class PaymentsGatewayError(BaseServiceError):
+class PaymentsGatewayError(_BaseServiceInternalError):
     ...