fix some review suggestions

Author: andreyorst

packages/aidbox-client/package.json

@@ -20,6 +20,7 @@
 		"lint": "biome check",
 		"lint:check": "biome check",
 		"lint:fix": "biome check --write",
+		"tsc:check": "tsc -b --noEmit",
 		"typecheck": "tsc -b --noEmit",
 		"generate-types": "tsx scripts/generate-types.ts",
 		"test": "vitest run",

packages/aidbox-client/src/client.ts

@@ -65,26 +65,26 @@ const isInternalErrorResponse = (
  *
  */
 export function makeClient<TBundle, TOperationOutcome, TUser>({
-	baseurl,
+	baseUrl,
 	onResponse = undefined,
 }: ClientParams): FhirServerClient<TBundle, TOperationOutcome, TUser> {
-	const getBaseURL = (): string => {
-		return baseurl;
+	const getBaseUrl = (): string => {
+		return baseUrl;
 	};
 
 	// TODO: async response pattern
 	const internalRawRequest = async (
 		requestParams: RequestParams,
 	): Promise<ResponseWithMeta | InternalAidboxErrorResponse> => {
-		const startTime = Date.now();
-		const baseURL = getBaseURL();
+		const startTime = performance.now();
+		const baseURL = getBaseUrl();
 
 		if (!requestParams.url.startsWith("/"))
 			return {
-				error: new RequestError("url must start with a forward slash", {
+				error: new RequestError("URL must start with a forward slash", {
 					request: requestParams,
 				}),
-				duration: Date.now() - startTime,
+				duration: performance.now() - startTime,
 				request: requestParams,
 			};
 
@@ -128,7 +128,7 @@ export function makeClient<TBundle, TOperationOutcome, TUser>({
 			return {
 				response,
 				responseHeaders,
-				duration: Date.now() - startTime,
+				duration: performance.now() - startTime,
 				request,
 			};
 		} catch (e) {
@@ -142,7 +142,7 @@ export function makeClient<TBundle, TOperationOutcome, TUser>({
 						request: request,
 					},
 				),
-				duration: Date.now() - startTime,
+				duration: performance.now() - startTime,
 				request,
 			};
 		}
@@ -519,7 +519,7 @@ export function makeClient<TBundle, TOperationOutcome, TUser>({
 
 	return {
 		// General
-		getBaseURL,
+		getBaseUrl,
 		rawRequest,
 		request,
 		// Aidbox

packages/aidbox-client/src/types.ts

@@ -29,7 +29,7 @@ export type Parameters = [string, string][];
 export type Headers = Record<string, string>;
 
 export type ClientParams = {
-	baseurl: string;
+	baseUrl: string;
 	onResponse?: (resp: Response) => void;
 };
 
@@ -39,7 +39,7 @@ export type User = Resource & {
 };
 
 export type RequestParams = {
-	method: "GET" | "POST" | "PUT" | "DELETE" | "PATCH";
+	method: "GET" | "POST" | "PUT" | "DELETE" | "PATCH" | "OPTIONS";
 	url: string;
 	headers?: Headers;
 	params?: Parameters;
@@ -86,7 +86,7 @@ export type FhirServerClient<
 	TOperationOutcome = OperationOutcome,
 	TUser = User,
 > = {
-	getBaseURL: () => string;
+	getBaseUrl: () => string;
 	/**
 	 * Untyped request.
 	 *

packages/aidbox-client/test/client.test.ts

@@ -42,7 +42,7 @@ describe("AidboxClient", () => {
       });
 
       const client = makeClient<Bundle, OperationOutcome, User>({
-        baseurl: "http://localhost:8080",
+        baseUrl: "http://localhost:8080",
       });
 
       const result: Result<ResourceResponse<Bundle>, ResourceResponse<OperationOutcome>> = await client.request<Bundle>({

packages/aidbox-client/test/fhir-http.test.ts

@@ -6,7 +6,7 @@ import { makeClient } from "src/client.js";
 // import type { User, ResourceResponse } from "src/types";
 // import type { Result } from "src/result";
 
-const client = makeClient<Bundle, OperationOutcome, User>({ baseurl: "http://localhost:8080" });
+const client = makeClient<Bundle, OperationOutcome, User>({ baseUrl: "http://localhost:8080" });
 
 const patientId = "pt-test-id";