Skip to content

[hl] add tgroup for number check, add tests and fixes #12418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yuxiaomao wants to merge 5 commits into
base: development
Choose a base branch
from
Open

[hl] add tgroup for number check, add tests and fixes #12418

yuxiaomao wants to merge 5 commits into from
+584 −291

Conversation

@yuxiaomao
Copy link
Contributor

@yuxiaomao yuxiaomao commented Nov 28, 2025 •
edited
Loading

Introduce tgroup to simplify some number-related code logic.

The following failing cases are fixed by this PR

  • Array<UI8> does not work correctly on get / compare
  • Don't know how to cast null(i32) to ui16, etc
  • Compare hl.I64 with Int are cast to Int instead of I64 (Int64)
  • Null<hl.GUID> crash the debugger (format.hl.Reader)
  • ... and maybe others

Fixed in hashlink

  • run t(a.ui8 % b.ui8 == 18); 5 times and 2 of them (3rd and 5th) will fail

@yuxiaomao yuxiaomao mentioned this pull request Dec 2, 2025
Merged
@yuxiaomao yuxiaomao marked this pull request as ready for review December 3, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yuxiaomao