Skip to content

CLI Unit tests could cover more (all?) CLI options #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sundar-mudupalli-work opened this issue Nov 11, 2024 · 3 comments · May be fixed by #1421
Open

CLI Unit tests could cover more (all?) CLI options #1327

sundar-mudupalli-work opened this issue Nov 11, 2024 · 3 comments · May be fixed by #1421
Assignees
@safe049
Labels
good first issue Good issue for new DVT contributors priority: p1 High priority. Fix may be included in the next release. type: testing

Comments

@sundar-mudupalli-work
Copy link
Collaborator

Hi,

Issue 1325 highlighted that a bug introduced in PR 1310 could have been easily caught with a more comprehensive CLI unit test. We have CLI unit tests, but don't cover all the options - just one column validation CLI test.

Let us make a CLI unit test will the documented options.

Thanks.

Sundar Mudupalli
Merged
@sundar-mudupalli-work sundar-mudupalli-work added the good first issue Good issue for new DVT contributors label Nov 12, 2024
@safe049
Copy link

safe049 commented Nov 15, 2024

i'd like to do this
may you assign me?

@helensilva14 helensilva14 added priority: p1 High priority. Fix may be included in the next release. type: testing labels Nov 25, 2024
@helensilva14
Copy link
Collaborator

helensilva14 commented Nov 25, 2024 •
edited
Loading

Hi @safe049, assignment done! Thank you for your collaboration!

@safe049 safe049 mentioned this issue Feb 2, 2025
Closed
@safe049
Copy link

safe049 commented Feb 2, 2025

Here you are!
#1421

@helensilva14 helensilva14 linked a pull request Feb 3, 2025 that will close this issue
test: Added more unit tests for CLI options #1421
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safe049 safe049

Labels
good first issue Good issue for new DVT contributors priority: p1 High priority. Fix may be included in the next release. type: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Added more unit tests for CLI options safe049/professional-services-data-validator
3 participants
@helensilva14 @safe049 @sundar-mudupalli-work