Skip to content

Conversation

@Guiners
Copy link
Contributor

@Guiners Guiners commented Nov 6, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners November 6, 2025 09:19
@snippet-bot
Copy link

snippet-bot bot commented Nov 6, 2025

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 6, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the image generation capabilities demonstrated in the Google GenAI SDK samples. It introduces a suite of new examples that illustrate how to leverage various reference image types—such as Canny, Scribble, Raw, Style, and Subject/Control combinations—to guide and refine the image generation process from text prompts. These additions provide developers with practical, ready-to-use code for advanced image manipulation and creation, complete with corresponding tests to validate their functionality.

Highlights

  • New Image Generation Samples: Introduced six new samples demonstrating various image generation capabilities using the Google GenAI SDK, including text-to-image generation with different reference image types.
  • Reference Image Control Types: Added samples showcasing advanced control over image generation through Canny edge detection, raw reference images, scribble control, style references, and a combination of subject and control references.
  • Comprehensive Testing: Each new image generation sample is accompanied by a dedicated test file, ensuring functionality and providing examples for testing image generation outputs.
  • GCS Output Utility: A new utility file (imggen-util.js) was added to assist with creating and cleaning up Google Cloud Storage (GCS) URIs for test outputs, streamlining the testing process for image generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several new samples for image generation with the GenAI SDK, along with corresponding tests. The changes are well-structured and cover various features like control references, style references, and subject references.

I've found a few issues that need addressing:

  • There are a couple of critical bugs in genai/image-generation/imggen-raw-reference-with-txt-img.js and genai/test/imggen-util.js that will cause the sample and tests to fail.
  • The imggen-raw-reference-with-txt-img.js sample is inconsistent with others in terms of return value and logging.
  • There's a minor readability improvement possible in imggen-subj-refer-ctrl-refer-with-txt-imgs.js.

Please see my detailed comments for suggestions on how to fix these.

Guiners and others added 6 commits November 6, 2025 10:34
outputGcsUri: outputGcsUri,
},
});
console.log(response.generatedImages);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this assumes that it works and you should check the response rather than just logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants