-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(genai): Adding imggen samples #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @Guiners, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the image generation capabilities demonstrated in the Google GenAI SDK samples. It introduces a suite of new examples that illustrate how to leverage various reference image types—such as Canny, Scribble, Raw, Style, and Subject/Control combinations—to guide and refine the image generation process from text prompts. These additions provide developers with practical, ready-to-use code for advanced image manipulation and creation, complete with corresponding tests to validate their functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several new samples for image generation with the GenAI SDK, along with corresponding tests. The changes are well-structured and cover various features like control references, style references, and subject references.
I've found a few issues that need addressing:
- There are a couple of critical bugs in
genai/image-generation/imggen-raw-reference-with-txt-img.jsandgenai/test/imggen-util.jsthat will cause the sample and tests to fail. - The
imggen-raw-reference-with-txt-img.jssample is inconsistent with others in terms of return value and logging. - There's a minor readability improvement possible in
imggen-subj-refer-ctrl-refer-with-txt-imgs.js.
Please see my detailed comments for suggestions on how to fix these.
genai/image-generation/imggen-subj-refer-ctrl-refer-with-txt-imgs.js
Outdated
Show resolved
Hide resolved
…mgs.js Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| outputGcsUri: outputGcsUri, | ||
| }, | ||
| }); | ||
| console.log(response.generatedImages); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this assumes that it works and you should check the response rather than just logging.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.