add optional cache for GetMetricKind calls #867
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -509,9 +512,20 @@ func (t *Translator) ListMetricDescriptors(fallbackForContainerMetrics bool) *st | |||
| Filter(filter) | |||
| } | |||
|
|
|||
| type cachedMetricInfo struct { | |||
There was a problem hiding this comment.
replace it with LRUExpireCache https://pkg.go.dev/k8s.io/apimachinery/pkg/util/cache
There was a problem hiding this comment.
Thanks, updated. I put some initial values here that i think would work. Let me know if we want to make this configurable.
There was a problem hiding this comment.
Let me know if we want to make this configurable.
Yes, it will be better to make it configurable. And this feature can be turned off by default.
If we find more users are complaining this issue, we can make it turned on by default later.
There was a problem hiding this comment.
MetricKindCacheSize:
- When it's 0, it doesn't use the cache
- When it's not 0, it uses the cache
DP19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #866
This allows responses for
MetricDescriptors.Getto be cached as to not hit the quota limit described in the linked issue