-
Notifications
You must be signed in to change notification settings - Fork 981
VPN monitoring is using non-supported query language #2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good catch @markusl - can you take a stab at a PR? |
@sruffilli unfortunately, we do not have the experience or the time at hand to be able to implement new features into the FAST framework. Do you have any estimate of when you would be able to implement this? The deprecation date of MQL is in just a few months, so there is not much time left. |
I don't think we have the bandwidth to tackle this TBH. Someone will eventually care enough to do it, hopefully. |
Had a quick internal discussion, and let me provide some background to our initial reaction above. First, as should be clear by the license we adopt and how this repo is managed, this is not an official GCP product but an Open Source project where we share with customers assets that originate from our daily work, and we think might be useful to them. And this mostly comes at substantial investment in personal time, as happens with most Open Source projects. So when we say that we don't have bandwidth, this is exactly what we mean: the demands of our day job are too high, or our limited time needs to be invested in changes that directly facilitate it. We're all humans, and we need sleep and family time. Then of course, anyone can submit a PR to fix/add features and we actually welcome them and work hard to allow users to contribute to this project. That said, we've been having internal discussions and there might be a way to prioritize this, so stay tuned. :) |
Hi! Thank you for the clear explanation and transparency about the project's nature and challenges. I appreciate your effort to balance a demanding job with sharing valuable work! Our context is that we deployed the solution about a year ago, and we were caught by surprise when we found out that one of the core components of Google Cloud (MQL) is being deprecated with such a rapid schedule. In just a few months, the code from the repository would not deploy anymore:
Obviously, this is not the fault of the repository maintainers, but it should be managed somehow by the project team working on the MQL deprecation. From our perspective, the VPN connection is critical infrastructure for our workloads and we appreciate if there will be some kind of solution to keep all parts in up-to-date versions. Thank for your efforts so far :) |
Affected components
The problem
It seems that the VPN monitoring solution used in FAST is using deprecated query language. See the code at
cloud-foundation-fabric/fast/stages/2-networking-a-simple/monitoring-vpn.tf
Line 72 in c832b61
This causes a warning in GCP console.

We are hoping to see the component upgraded to PromQL as recommended by Google Cloud. This would allow us to ensure our production systems work without interruptions
Release version
1
Terraform version
Terraform v1.11.0-rc3
Steps to reproduce
Check the code and see it uses
condition_monitoring_query_language
Expected behavior
The code base should use generally available and supported platform components.
Actual behavior
Additional context
No response
The text was updated successfully, but these errors were encountered: