fix: ensure that default spanner API is batch-spanner.googleapis.com #2321
+14
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the dataflow templates use the incorrect endpoint for batch spanner actions. Fixes GoogleCloudPlatform#2304
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
============================================
- Coverage 49.24% 49.18% -0.07%
+ Complexity 4617 4616 -1
============================================
Files 924 924
Lines 55779 55852 +73
Branches 5995 5998 +3
============================================
- Hits 27471 27469 -2
- Misses 26331 26406 +75
Partials 1977 1977
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the dataflow templates use the incorrect endpoint for batch spanner actions.
This PR renames the defaults from spanner.googleapis.com to batch-spanner.googleapis.com to match the default host in Beam SpannerIO
Fixes #2304