Add support for stereo playback #1560
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be either VOICE_COMMUNICATION or MEDIA
…and usage_voice_communication
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
PratimMallick
requested review from
rahul-lohra
and removed request for
a team
SDK Size Comparison 📏
|
aleksandar-apostolov
changed the title
aleksandar-apostolov
changed the title
aleksandar-apostolov
changed the title
aleksandar-apostolov
changed the title
…one when adding stereo capture to recording feature
PratimMallick
changed the title
PratimMallick
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To enable stereo playout and provide ability to switch between stereo and mono playout mid call
Implementation
Provided
setAudioUsagemethod onSpeakerManagerthat can be used after joining a call to change the current audio mode fromVOICE_COMMUNICATIONtoMEDIAthat will enable stereo playout.A StateFlow
audioUsageis added as well which apps can observe to know the current audio usageTesting
A debug option is added in the debug menu option to toggle between mono and stereo playout.
To test stereo output, join a call from android and play a screenshare track from youtube on web containing stereo sound. Toggle to stereo mode from android and observe the stereo effect.